Skip to content

Update rule repository#7

Merged
NicholasEllul merged 2 commits intomainfrom
ellul/rule-updates
Jan 24, 2025
Merged

Update rule repository#7
NicholasEllul merged 2 commits intomainfrom
ellul/rule-updates

Conversation

@NicholasEllul
Copy link
Contributor

@NicholasEllul NicholasEllul commented Jan 20, 2025

Summary

This pull request makes some refinements to the existing publish-actions-cache-used rule, and removes the example hello-world rule. The example rule is now obsolete given the addition of contributing docs and example template.

Ways to validate this PR?

  1. Check to see that CI has passed which runs bin/test and bin/validate-rules.
  2. Clone this branch locally and run semgrep --config rules/src/ path/to/directory to see the rule applied in action.

@NicholasEllul NicholasEllul requested a review from a team as a code owner January 20, 2025 21:08
- pattern: "uses: $ACTION_NAME"
- metavariable-regex:
metavariable: $ACTION_NAME
regex: actions/cache@.+
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows wider range of matching rather than single digit

patterns:
- patterns:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes redundant patterns nesting

Copy link

@mmenoxx mmenoxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicholasEllul NicholasEllul merged commit 0e3b3f5 into main Jan 24, 2025
1 check passed
@NicholasEllul NicholasEllul deleted the ellul/rule-updates branch January 24, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants