feat: adapt rule to identify caching via actions/setup-node#9
Merged
NicholasEllul merged 2 commits intomainfrom Mar 14, 2025
Merged
feat: adapt rule to identify caching via actions/setup-node#9NicholasEllul merged 2 commits intomainfrom
NicholasEllul merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
PR Overview
This PR enhances our caching rule to also detect caching implemented via actions/setup-node.
- Introduces a new pattern-either block in the rule YAML to identify both actions/cache and actions/setup-node usage.
- Adds a new test case in the test YAML to validate the updated rule behavior.
Reviewed Changes
| File | Description |
|---|---|
| rules/src/github-actions/publish-actions-cache-used.yaml | Updates the rule logic to detect caching when actions/setup-node is used. |
| rules/test/github-actions/publish-actions-cache-used.test.yaml | Adds a test scenario to verify the updated caching detection rule. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adapts our existing rule to be capable of flagging caching when performed through usage of
actions/setup-node.