-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Yarn v1 to v3 #137
Conversation
This commit aligns this project with our other projects, which use Yarn v3 across the board. The new files here are copied from the module template.
3576315
to
446bed5
Compare
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Ignoring: Pull request alert summary
📊 Modified Dependency Overview:
|
These are our packages: @SocketSecurity ignore @lavamoat/aa@3.1.2 |
I figure the new lint errors comes from the lockfile reset + a semver-minor bump of something |
@legobeat Hmm, this PR shouldn't update Prettier. Bumping all dev dependencies is a good idea, but I think if we ensure that Prettier isn't bumped, this PR can be independent of your changes. I'll see if I can fix that. |
The newer version of prettier is already in range, so it's questionable (I'm not sure where I stand on this) if it should be considered an upgrade - users installing from a fresh clone without the lockfile would already get the errors here. But assuming we want to do both either way, it seems arbitrary if we do |
|
package.json
Outdated
@@ -15,13 +15,11 @@ | |||
"scripts": { | |||
"build": "tsc --project .", | |||
"build:clean": "rm -rf dist && yarn build", | |||
"build:link": "yarn build && cd dist && yarn link && rm -rf node_modules && cd ..", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting for future readers that this was originally added in 1a6c749 as developer convenience and I guess is something we expect users to figure out themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@legobeat Good point. My understanding was that the yarn link
process was broken, but I should follow up on that. I will keep this around for now in case it is still being used.
|
|
This commit aligns this project with our other projects, which use Yarn v3 across the board.
The new files here are copied from the module template.