Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 2, 2025

Note

Updates multiple locale files to add domain name resolution messaging in send flow and refine confirmation and transaction error translations across languages.

  • Localization (multiple languages in packages/snap/locales/*.json):
    • Send flow:
      • Update send.toPlaceholder to accept domain names; broaden send.toInvalidError and add send.toInvalidErrorDomain.
      • Add domain resolution status keys: send.toDomainResolutionStatus.{initial,fetching,fetched,error}.
    • Confirmation UI:
      • Localize confirmation.signTransaction.title, confirmation.sendAndConfirmTransaction.title, and confirmation.origin.tooltip.
      • Tweak confirmation.simulationErrorSubtitle to just {reason} across locales.
    • Errors:
      • Improve translations for transactionScan.errors.{accountAlreadyInUse,insufficientSol,slippageToleranceExceeded,unknownError}.

Written by Cursor Bugbot for commit 1bac7c9. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from aac49a5 to 8d79c13 Compare July 2, 2025 11:32
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 8d79c13 to f6d9b95 Compare July 2, 2025 12:23
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from f6d9b95 to 5b0c3fd Compare July 2, 2025 12:54
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 5b0c3fd to c039aa9 Compare July 2, 2025 15:38
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from c039aa9 to 2bcd882 Compare July 2, 2025 15:43
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 2bcd882 to f13011d Compare July 4, 2025 09:40
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from f13011d to 35ab39c Compare July 4, 2025 14:55
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 35ab39c to 9eb3655 Compare July 7, 2025 10:30
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 9eb3655 to 48afeab Compare July 9, 2025 14:42
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 48afeab to 6884681 Compare July 9, 2025 14:56
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 6884681 to f47f69d Compare July 9, 2025 15:36
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from f47f69d to e41b1ab Compare July 10, 2025 09:00
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from e41b1ab to 7d20b9e Compare July 10, 2025 09:27
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 7d20b9e to bf543f2 Compare July 10, 2025 10:04
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from bf543f2 to 2ef1ba3 Compare July 10, 2025 10:07
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 4 times, most recently from 4261d14 to 4ec1786 Compare September 29, 2025 13:37
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 4 times, most recently from 8140ea8 to 7235d61 Compare October 8, 2025 18:15
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 3 times, most recently from 2068b1d to b1aa34c Compare October 13, 2025 12:32
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent Translation Formats Across Locales

The confirmation.simulationErrorSubtitle translation has an inconsistent format across locales. Russian, Tagalog, Hindi, and Chinese files retain the "Reason: {reason}" prefix, while most other languages were updated to remove it. This creates a fragmented user experience.

packages/snap/locales/hi.json#L199-L200

"confirmation.simulationErrorSubtitle": {
"message": "वजह: {reason}"

packages/snap/locales/tl.json#L199-L200

"confirmation.simulationErrorSubtitle": {
"message": "Dahilan: {reason}"

packages/snap/locales/zh.json#L199-L200

"confirmation.simulationErrorSubtitle": {
"message": "原因:{reason}"

packages/snap/locales/ru.json#L199-L200

"confirmation.simulationErrorSubtitle": {
"message": "Причина: {reason}"

Fix in Cursor Fix in Web


@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 7 times, most recently from 52921f1 to 65b5970 Compare October 15, 2025 12:25
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 65b5970 to a26607f Compare November 6, 2025 14:30
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 9a9c8bc to f9d03a2 Compare November 7, 2025 13:05
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from f9d03a2 to 93816f7 Compare November 20, 2025 15:30
},
"confirmation.origin.tooltip": {
"message": "This is the site asking for your confirmation."
"message": "यह वही साइट है जो आपका कन्फर्मेशन मांग रही है।"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent simulationErrorSubtitle updates across locales

The confirmation.simulationErrorSubtitle message was not updated in Hindi (and Russian, Tagalog files). All other language files were changed from prefixed format (e.g., "Reason: {reason}") to just "{reason}" for consistency, but these three files were missed, creating an inconsistent user experience across languages.

Fix in Cursor Fix in Web

},
"confirmation.origin.tooltip": {
"message": "This is the site asking for your confirmation."
"message": "Это сайт, запрашивающий ваше подтверждение."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent simulationErrorSubtitle updates across locales

The confirmation.simulationErrorSubtitle message was not updated in Russian (and Hindi, Tagalog files). All other language files were changed from prefixed format (e.g., "Причина: {reason}") to just "{reason}" for consistency, but these three files were missed, creating an inconsistent user experience across languages.

Fix in Cursor Fix in Web

},
"confirmation.origin.tooltip": {
"message": "This is the site asking for your confirmation."
"message": "Hinihingi ng site na ito ang iyong kumpirmasyon."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent simulationErrorSubtitle updates across locales

The confirmation.simulationErrorSubtitle message was not updated in Tagalog (and Hindi, Russian files). All other language files were changed from prefixed format (e.g., "Dahilan: {reason}") to just "{reason}" for consistency, but these three files were missed, creating an inconsistent user experience across languages.

Fix in Cursor Fix in Web

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from ff371c7 to b4ae42b Compare November 26, 2025 13:10
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from b4ae42b to 1bac7c9 Compare November 26, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants