-
-
Notifications
You must be signed in to change notification settings - Fork 4
New Crowdin translations by Github Action #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
aac49a5 to
8d79c13
Compare
8d79c13 to
f6d9b95
Compare
f6d9b95 to
5b0c3fd
Compare
5b0c3fd to
c039aa9
Compare
c039aa9 to
2bcd882
Compare
2bcd882 to
f13011d
Compare
f13011d to
35ab39c
Compare
35ab39c to
9eb3655
Compare
9eb3655 to
48afeab
Compare
48afeab to
6884681
Compare
6884681 to
f47f69d
Compare
f47f69d to
e41b1ab
Compare
e41b1ab to
7d20b9e
Compare
7d20b9e to
bf543f2
Compare
bf543f2 to
2ef1ba3
Compare
4261d14 to
4ec1786
Compare
8140ea8 to
7235d61
Compare
2068b1d to
b1aa34c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent Translation Formats Across Locales
The confirmation.simulationErrorSubtitle translation has an inconsistent format across locales. Russian, Tagalog, Hindi, and Chinese files retain the "Reason: {reason}" prefix, while most other languages were updated to remove it. This creates a fragmented user experience.
packages/snap/locales/hi.json#L199-L200
snap-solana-wallet/packages/snap/locales/hi.json
Lines 199 to 200 in b1aa34c
| "confirmation.simulationErrorSubtitle": { | |
| "message": "वजह: {reason}" |
packages/snap/locales/tl.json#L199-L200
snap-solana-wallet/packages/snap/locales/tl.json
Lines 199 to 200 in b1aa34c
| "confirmation.simulationErrorSubtitle": { | |
| "message": "Dahilan: {reason}" |
packages/snap/locales/zh.json#L199-L200
snap-solana-wallet/packages/snap/locales/zh.json
Lines 199 to 200 in b1aa34c
| "confirmation.simulationErrorSubtitle": { | |
| "message": "原因:{reason}" |
packages/snap/locales/ru.json#L199-L200
snap-solana-wallet/packages/snap/locales/ru.json
Lines 199 to 200 in b1aa34c
| "confirmation.simulationErrorSubtitle": { | |
| "message": "Причина: {reason}" |
52921f1 to
65b5970
Compare
65b5970 to
a26607f
Compare
9a9c8bc to
f9d03a2
Compare
f9d03a2 to
93816f7
Compare
| }, | ||
| "confirmation.origin.tooltip": { | ||
| "message": "This is the site asking for your confirmation." | ||
| "message": "यह वही साइट है जो आपका कन्फर्मेशन मांग रही है।" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent simulationErrorSubtitle updates across locales
The confirmation.simulationErrorSubtitle message was not updated in Hindi (and Russian, Tagalog files). All other language files were changed from prefixed format (e.g., "Reason: {reason}") to just "{reason}" for consistency, but these three files were missed, creating an inconsistent user experience across languages.
| }, | ||
| "confirmation.origin.tooltip": { | ||
| "message": "This is the site asking for your confirmation." | ||
| "message": "Это сайт, запрашивающий ваше подтверждение." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent simulationErrorSubtitle updates across locales
The confirmation.simulationErrorSubtitle message was not updated in Russian (and Hindi, Tagalog files). All other language files were changed from prefixed format (e.g., "Причина: {reason}") to just "{reason}" for consistency, but these three files were missed, creating an inconsistent user experience across languages.
| }, | ||
| "confirmation.origin.tooltip": { | ||
| "message": "This is the site asking for your confirmation." | ||
| "message": "Hinihingi ng site na ito ang iyong kumpirmasyon." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent simulationErrorSubtitle updates across locales
The confirmation.simulationErrorSubtitle message was not updated in Tagalog (and Hindi, Russian files). All other language files were changed from prefixed format (e.g., "Dahilan: {reason}") to just "{reason}" for consistency, but these three files were missed, creating an inconsistent user experience across languages.
ff371c7 to
b4ae42b
Compare
b4ae42b to
1bac7c9
Compare
Note
Updates multiple locale files to add domain name resolution messaging in send flow and refine confirmation and transaction error translations across languages.
packages/snap/locales/*.json):send.toPlaceholderto accept domain names; broadensend.toInvalidErrorand addsend.toInvalidErrorDomain.send.toDomainResolutionStatus.{initial,fetching,fetched,error}.confirmation.signTransaction.title,confirmation.sendAndConfirmTransaction.title, andconfirmation.origin.tooltip.confirmation.simulationErrorSubtitleto just{reason}across locales.transactionScan.errors.{accountAlreadyInUse,insufficientSol,slippageToleranceExceeded,unknownError}.Written by Cursor Bugbot for commit 1bac7c9. This will update automatically on new commits. Configure here.