webpack injects document into bundle, which fails eval

[rygine]

working build on main branch here: https://github.com/xmtp/snap

failing build on branch rygine/upgrade-sdk. the only change is upgrading our SDK version.

i'm seeing the following error during the eval stage: ReferenceError: document is not defined

after tracking down where document is used, i discovered that it appears to be injected into the bundle via the JsonpChunkLoadingRuntimeModule class used by webpack (source).

nothing has changed in our SDK with regards to the use of document or window.document.

please advise. thanks!

[Mrtenz]

Does this solve the problem? This should disable JsonpChunkLoadingRuntimeModule.

import type { SnapConfig } from '@metamask/snaps-cli';
import { merge } from '@metamask/snaps-cli';

const config: SnapConfig = {
  // ...
  customizeWebpackConfig: (baseConfig) => {
    return merge(baseConfig, {
      output: {
        chunkFormat: 'commonjs',
      },
    });
  },
};

export default config;

[rygine]

that fixed it, thanks!

[Mrtenz]

Glad to hear! I'll submit a PR to get this enabled by default.