Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Support Interactive UI in snaps-jest #2286

Merged
merged 9 commits into from
Mar 27, 2024

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Mar 18, 2024

This adds new methods to support user interactions in snaps-jest.

  • Add clickElement method to allow a click simulation on an element.
  • Add typeInField method to allow field typing simulation.
  • Add those new methods to getInteface result for snap_dialog.
  • [BREAKING] Refactor the snap handler result object to remove the static content field and replace it with getInterface, this allows to get the interface after an update due to a user interaction.

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner March 18, 2024 16:03
@GuillaumeRx GuillaumeRx force-pushed the gr/add-interactive-ui-test-snap branch from ae4c72c to 57f4da4 Compare March 22, 2024 14:54
@GuillaumeRx GuillaumeRx changed the title [WIP] Support Interactive UI in snaps-jest [BREAKING] Support Interactive UI in snaps-jest Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (de7fc0e) to head (28c1183).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2286      +/-   ##
==========================================
+ Coverage   96.59%   96.63%   +0.03%     
==========================================
  Files         337      337              
  Lines        7615     7689      +74     
  Branches     1180     1193      +13     
==========================================
+ Hits         7356     7430      +74     
  Misses        259      259              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Mostly just some questions/nits.

@GuillaumeRx GuillaumeRx requested a review from Mrtenz March 26, 2024 13:50
Mrtenz
Mrtenz previously approved these changes Mar 27, 2024
@GuillaumeRx GuillaumeRx merged commit 51a1d04 into main Mar 27, 2024
150 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/add-interactive-ui-test-snap branch March 27, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants