-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Support Interactive UI in snaps-jest
#2286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeRx
force-pushed
the
gr/add-interactive-ui-test-snap
branch
from
March 22, 2024 14:54
ae4c72c
to
57f4da4
Compare
GuillaumeRx
changed the title
[WIP] Support Interactive UI in
[BREAKING] Support Interactive UI in Mar 22, 2024
snaps-jest
snaps-jest
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2286 +/- ##
==========================================
+ Coverage 96.59% 96.63% +0.03%
==========================================
Files 337 337
Lines 7615 7689 +74
Branches 1180 1193 +13
==========================================
+ Hits 7356 7430 +74
Misses 259 259 ☔ View full report in Codecov by Sentry. |
Mrtenz
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Mostly just some questions/nits.
Mrtenz
previously approved these changes
Mar 27, 2024
GuillaumeRx
force-pushed
the
gr/add-interactive-ui-test-snap
branch
from
March 27, 2024 12:10
e0b1903
to
28c1183
Compare
Mrtenz
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new methods to support user interactions in
snaps-jest
.clickElement
method to allow a click simulation on an element.typeInField
method to allow field typing simulation.getInteface
result forsnap_dialog
.content
field and replace it withgetInterface
, this allows to get the interface after an update due to a user interaction.