Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add snap_getInterfaceContext #2902

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Nov 21, 2024

Expose a new RPC method snap_getInterfaceContext that makes the context easily accessible outside onUserInput. Also adds the necessary wiring to make this RPC method work in the simulation environment.

This feature will require the addition of a getInterfaceContext method hook in the clients.

Progresses #2901

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.48%. Comparing base (126990b) to head (399e937).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/snaps-simulator/src/features/simulation/sagas.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2902   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files         486      487    +1     
  Lines       10405    10427   +22     
  Branches     1597     1598    +1     
=======================================
+ Hits         9831     9852   +21     
- Misses        574      575    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@FrederikBolding FrederikBolding marked this pull request as ready for review November 21, 2024 13:15
@FrederikBolding FrederikBolding requested a review from a team as a code owner November 21, 2024 13:15
GuillaumeRx
GuillaumeRx previously approved these changes Nov 21, 2024
GuillaumeRx
GuillaumeRx previously approved these changes Nov 21, 2024
@FrederikBolding FrederikBolding merged commit 45db6e7 into main Nov 22, 2024
166 checks passed
@FrederikBolding FrederikBolding deleted the fb/get-interface-context branch November 22, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants