-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add snap_getInterfaceContext
#2902
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2902 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 486 487 +1
Lines 10405 10427 +22
Branches 1597 1598 +1
=======================================
+ Hits 9831 9852 +21
- Misses 574 575 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
GuillaumeRx
previously approved these changes
Nov 21, 2024
GuillaumeRx
previously approved these changes
Nov 21, 2024
FrederikBolding
commented
Nov 21, 2024
packages/snaps-rpc-methods/src/permitted/getInterfaceContext.test.ts
Outdated
Show resolved
Hide resolved
GuillaumeRx
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose a new RPC method
snap_getInterfaceContext
that makes thecontext
easily accessible outsideonUserInput
. Also adds the necessary wiring to make this RPC method work in the simulation environment.This feature will require the addition of a
getInterfaceContext
method hook in the clients.Progresses #2901