Fix example build script #3116
Merged
Fix example build script #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3116 +/- ##
=======================================
Coverage 94.88% 94.88%
=======================================
Files 506 506
Lines 11121 11121
Branches 1709 1709
=======================================
Hits 10552 10552
Misses 569 569 ☔ View full report in Codecov by Sentry. |
FrederikBolding
approved these changes
Feb 17, 2025
hmalik88
reviewed
Feb 17, 2025
| @@ -20,7 +20,7 @@ | |||
| "sideEffects": false, | |||
| "files": [], | |||
| "scripts": { | |||
| "build": "yarn workspaces foreach --worktree --parallel --verbose --no-private run build", | |||
| "build": "yarn workspaces filter --include 'packages/examples/packages/**' --parallel --no-private run build", | |||
There was a problem hiding this comment.
What's the difference between doing yarn workspaces filter --include and yarn workspaces foreach --include? Why don't we need --verbose any more?
There was a problem hiding this comment.
--verbose doesn't exist on filter
There was a problem hiding this comment.
workspaces filter's --include supports glob patterns, whereas workspaces foreach only supports exact package names. --verbose is also enabled by default on workspaces filter.
Mrtenz
force-pushed
the
mrtenz/example-build-script
branch
from
0eaa757 to
74b9bc0
Compare
Mrtenz
added a commit
to Mrtenz/snaps
that referenced
this pull request
Mar 13, 2025
This reverts commit f17d19d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build script for examples broke in #3094. Using the
filtercommand seems to be the easiest way to get it working again.