feat: Add AssetSelector
#3166
Merged
feat: Add AssetSelector
#3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3166 +/- ##
==========================================
+ Coverage 94.93% 94.98% +0.04%
==========================================
Files 508 510 +2
Lines 11219 11303 +84
Branches 1730 1750 +20
==========================================
+ Hits 10651 10736 +85
+ Misses 568 567 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
GuillaumeRx
added a commit
to MetaMask/core
that referenced
this pull request
Mar 5, 2025
## Explanation This adds an action to the `MultichainAssetsController` called `getAssetMetada` which allows to get a specific asset Metadata. This allows us to get a specific metadata without having to pull the entire controller state. ## References * Related to MetaMask/snaps#3166 ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/assets-controller` - **ADDED**: Add `getAssetMetadata` action to `MultichainAssetsController`. ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
GuillaumeRx
force-pushed
the
gr/asset-selector
branch
from
97d2969 to
c47feb1
Compare
hmalik88
reviewed
Mar 12, 2025
hmalik88
reviewed
Mar 12, 2025
packages/snaps-controllers/src/interface/SnapInterfaceController.test.tsx
Show resolved
Hide resolved
hmalik88
reviewed
Mar 12, 2025
hmalik88
reviewed
Mar 12, 2025
hmalik88
reviewed
Mar 12, 2025
GuillaumeRx
force-pushed
the
gr/asset-selector
branch
from
e1cbe37 to
bd0292b
Compare
packages/snaps-controllers/src/interface/SnapInterfaceController.ts
Outdated
Show resolved
Hide resolved
packages/snaps-controllers/src/interface/SnapInterfaceController.ts
Outdated
Show resolved
Hide resolved
packages/snaps-controllers/src/interface/SnapInterfaceController.ts
Outdated
Show resolved
Hide resolved
packages/snaps-controllers/src/interface/SnapInterfaceController.test.tsx
Show resolved
Hide resolved
hmalik88
previously approved these changes
Mar 14, 2025
Working on it right now 🫡 |
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
… `CaipAccountIdsMatchedByAddressAndNamespaceStruct`
FrederikBolding
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new component
AssetSelector.Fixes: #3163