Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle withKeyring breaking change in MultichainRouter #3238

Merged

Conversation

FrederikBolding
Copy link
Member

KeyringController.withKeyring had a breaking change in MetaMask/core@8e15f01 where the format of the callback parameters was changed. This breaks the SIP-26 branch as the extension is already using the latest version of the KeyringController. This PR adjusts our usage of withKeyring to expect the new format.

@FrederikBolding FrederikBolding requested a review from a team as a code owner March 18, 2025 12:47
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.93%. Comparing base (adecea5) to head (6b6f171).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3238   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         508      508           
  Lines       11219    11219           
  Branches     1730     1730           
=======================================
  Hits        10651    10651           
  Misses        568      568           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit d1f1f0a Mar 18, 2025
173 checks passed
@FrederikBolding FrederikBolding deleted the fb/multichain-router-with-keyring-breaking-change branch March 18, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants