Skip to content

feat: Add NPM proxy support #3695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2025
Merged

feat: Add NPM proxy support #3695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8987138
feat: Add NPM proxy support
FrederikBolding Oct 22, 2025
725a9f2
Treat NPM proxy as real NPM
FrederikBolding Oct 22, 2025
4dda778
Use prod URL
FrederikBolding Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/snaps-controllers/src/snaps/SnapController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,6 +1516,7 @@ export class SnapController extends BaseController<
versionRange: resolvedVersion,
fetch: this.#fetchFunction,
allowLocal: false,
useNpmProxy: true,
});

await this.#updateSnap({
Expand Down
16 changes: 14 additions & 2 deletions packages/snaps-controllers/src/snaps/location/npm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ import type { DetectSnapLocationOptions, SnapLocation } from './location';

export const DEFAULT_NPM_REGISTRY = new URL('https://registry.npmjs.org');

export const NPM_REGISTRY_PROXY = new URL('https://npm-ota.api.cx.metamask.io');

type NpmMeta = {
registry: URL;
packageName: string;
Expand All @@ -48,6 +50,12 @@ export type NpmOptions = {
* @default false
*/
allowCustomRegistries?: boolean;
/**
* Whether to use a MetaMask-owned proxy when sending requests to NPM.
*
* @default false
*/
useNpmProxy?: boolean;
};

// Base class for NPM implementation, useful for extending with custom NPM fetching logic
Expand All @@ -74,7 +82,7 @@ export abstract class BaseNpmLocation implements SnapLocation {
url.username === '' &&
url.password === ''
) {
registry = DEFAULT_NPM_REGISTRY;
registry = opts.useNpmProxy ? NPM_REGISTRY_PROXY : DEFAULT_NPM_REGISTRY;
} else {
registry = 'https://';
if (url.username) {
Expand Down Expand Up @@ -341,7 +349,11 @@ export function getNpmCanonicalBasePath(registryUrl: URL, packageName: string) {
* @returns True if the registry is the NPM registry, otherwise false.
*/
function isNPM(registryUrl: URL) {
return registryUrl.toString() === DEFAULT_NPM_REGISTRY.toString();
const registryUrlString = registryUrl.toString();
return (
registryUrlString === DEFAULT_NPM_REGISTRY.toString() ||
registryUrlString === NPM_REGISTRY_PROXY.toString()
);
}

/**
Expand Down