Skip to content

chore: Bump @metamask/phishing-controller from 15.0.0 to 16.1.0 #3748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Bump @metamask/phishing-controller from 15.0.0 to 16.1.0 #3748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/snaps-controllers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"@metamask/messenger": "^0.3.0",
"@metamask/object-multiplex": "^2.1.0",
"@metamask/permission-controller": "^12.1.1",
"@metamask/phishing-controller": "^15.0.0",
"@metamask/phishing-controller": "^16.1.0",
Copy link

@cursor cursor bot Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing peer dependency for phishing controller upgrade

The upgrade to @metamask/phishing-controller@^16.1.0 introduces a peer dependency requirement for @metamask/transaction-controller@^62.0.0 (changed from ^61.0.0 in version 15.0.0). However, @metamask/transaction-controller is not listed as a dependency in any of the three packages (snaps-controllers, snaps-jest, snaps-simulation) that depend on the phishing controller. This unmet peer dependency will cause installation warnings or errors and potentially runtime issues if the phishing controller attempts to interact with the transaction controller.

Fix in Cursor Fix in Web

"@metamask/post-message-stream": "^10.0.0",
"@metamask/rpc-errors": "^7.0.3",
"@metamask/snaps-registry": "^3.3.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/snaps-jest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"@jest/types": "^29.6.3",
"@lavamoat/allow-scripts": "^3.4.0",
"@metamask/auto-changelog": "^5.0.2",
"@metamask/phishing-controller": "^15.0.0",
"@metamask/phishing-controller": "^16.1.0",
"@metamask/snaps-utils": "workspace:^",
"@swc/core": "1.11.31",
"@swc/jest": "^0.2.38",
Expand Down
2 changes: 1 addition & 1 deletion packages/snaps-simulation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@metamask/key-tree": "^10.1.1",
"@metamask/messenger": "^0.3.0",
"@metamask/permission-controller": "^12.1.1",
"@metamask/phishing-controller": "^15.0.0",
"@metamask/phishing-controller": "^16.1.0",
"@metamask/snaps-controllers": "workspace:^",
"@metamask/snaps-execution-environments": "workspace:^",
"@metamask/snaps-rpc-methods": "workspace:^",
Expand Down
20 changes: 10 additions & 10 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3014,7 +3014,7 @@ __metadata:
languageName: unknown
linkType: soft

"@metamask/controller-utils@npm:^11.14.1, @metamask/controller-utils@npm:^11.16.0":
"@metamask/controller-utils@npm:^11.16.0":
version: 11.16.0
resolution: "@metamask/controller-utils@npm:11.16.0"
dependencies:
Expand Down Expand Up @@ -3930,21 +3930,21 @@ __metadata:
languageName: node
linkType: hard

"@metamask/phishing-controller@npm:^15.0.0":
version: 15.0.0
resolution: "@metamask/phishing-controller@npm:15.0.0"
"@metamask/phishing-controller@npm:^16.1.0":
version: 16.1.0
resolution: "@metamask/phishing-controller@npm:16.1.0"
dependencies:
"@metamask/base-controller": "npm:^9.0.0"
"@metamask/controller-utils": "npm:^11.14.1"
"@metamask/controller-utils": "npm:^11.16.0"
"@metamask/messenger": "npm:^0.3.0"
"@noble/hashes": "npm:^1.8.0"
"@types/punycode": "npm:^2.1.0"
ethereum-cryptography: "npm:^2.1.2"
fastest-levenshtein: "npm:^1.0.16"
punycode: "npm:^2.1.1"
peerDependencies:
"@metamask/transaction-controller": ^61.0.0
checksum: 10/84e10ddcba9bb1351538c2de1105863dda030ad5f6dfa54bb17d731e436e948e6bcc4630fa914162046bda1b925514de37224f34cc00145e102b2f7f3f83059e
"@metamask/transaction-controller": ^62.0.0
checksum: 10/af956177cd1a3dd10150cefd8895cc479bb35bddd4ae751031985a89d929a9f63febf55462d09d9e6970612b00f5b90e27ff84dbb82f5ce503f8d429a4b0803b
languageName: node
linkType: hard

Expand Down Expand Up @@ -4262,7 +4262,7 @@ __metadata:
"@metamask/messenger": "npm:^0.3.0"
"@metamask/object-multiplex": "npm:^2.1.0"
"@metamask/permission-controller": "npm:^12.1.1"
"@metamask/phishing-controller": "npm:^15.0.0"
"@metamask/phishing-controller": "npm:^16.1.0"
"@metamask/post-message-stream": "npm:^10.0.0"
"@metamask/rpc-errors": "npm:^7.0.3"
"@metamask/snaps-registry": "npm:^3.3.0"
Expand Down Expand Up @@ -4389,7 +4389,7 @@ __metadata:
"@jest/types": "npm:^29.6.3"
"@lavamoat/allow-scripts": "npm:^3.4.0"
"@metamask/auto-changelog": "npm:^5.0.2"
"@metamask/phishing-controller": "npm:^15.0.0"
"@metamask/phishing-controller": "npm:^16.1.0"
"@metamask/snaps-controllers": "workspace:^"
"@metamask/snaps-sdk": "workspace:^"
"@metamask/snaps-simulation": "workspace:^"
Expand Down Expand Up @@ -4557,7 +4557,7 @@ __metadata:
"@metamask/key-tree": "npm:^10.1.1"
"@metamask/messenger": "npm:^0.3.0"
"@metamask/permission-controller": "npm:^12.1.1"
"@metamask/phishing-controller": "npm:^15.0.0"
"@metamask/phishing-controller": "npm:^16.1.0"
"@metamask/snaps-controllers": "workspace:^"
"@metamask/snaps-execution-environments": "workspace:^"
"@metamask/snaps-rpc-methods": "workspace:^"
Expand Down
Loading