Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Malformed Transactions #295

Merged
merged 11 commits into from
Mar 19, 2024
Merged

Add Malformed Transactions #295

merged 11 commits into from
Mar 19, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Feb 29, 2024

Description

Similarly to the Add Malformed Signatures PR, in this PR we are adding Malformed Transactions. It consists on the following:

Screenshots

Screenshot from 2024-03-06 15-16-06

malformed-tx.mp4

Manual QA

  1. Try Invalid Value Type --> you will see the error correctly displayed in the dapp
  2. Try Invalid Transaction Type --> warning: if you accept, you will encounter the issue mentioned in the description: having an unapproved tx on state, and unable to clean it
  3. Try Send with Odd Hex Data --> you will see data is still not normalized, since the issue is still not fixed in prod
  4. Try Approve with Odd Hex Data --> you will see that hex data is still not normalized and the fallback contract interaction screen appears (no Approve screen), since the issue is still not fixed in prod
  5. Try Invalid Recipient --> you will see the error correctly displayed in the dapp
  6. Try Invalid Gas Limit --> you will see a predefault gas limit set and MM does not break
  7. Try Invalid Max Gee per Gas --> you will see that MM breaks with the error mentioned in the description

@seaona seaona marked this pull request as ready for review February 29, 2024 10:35
@seaona seaona marked this pull request as draft February 29, 2024 10:52
@seaona seaona marked this pull request as ready for review March 6, 2024 14:46
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@seaona seaona changed the title add: malformed transactions Add Malformed Transactions Mar 6, 2024
src/index.js Outdated Show resolved Hide resolved
jpuri
jpuri previously approved these changes Mar 15, 2024
digiwand
digiwand previously approved these changes Mar 16, 2024
Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! added a minor suggestion to move github comments to code itself

@seaona seaona dismissed stale reviews from digiwand, jpuri, and pedronfigueiredo via 1f0a31a March 19, 2024 08:36
@seaona
Copy link
Contributor Author

seaona commented Mar 19, 2024

thank you for the reviews ❤️ @digiwand I've added the comments in the code as you suggested 🙏

@seaona seaona requested review from jpuri and digiwand March 19, 2024 12:54
@seaona seaona merged commit 2817bbd into main Mar 19, 2024
7 checks passed
@seaona seaona deleted the malformed-transactions branch March 19, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants