Skip to content

Add optional destroy method to Keyring type #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2023
Merged

Add optional destroy method to Keyring type #108

merged 1 commit into from
Jun 20, 2023

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Jun 20, 2023 •
edited
Loading

This PR adds the destroy optional method to the Keyring type.
Some keyrings like @metamask/eth-trezor-keyring and @metamask/eth-ledger-bridge-keyring support this method to remove hardware bridges and in some cases (Ledger) to remove listeners.

We need to add this method to the Keyring before migrating Trezor and Ledger keyrings to this type.

Changes

  • ADDED: Optional destroy method on Keyring type

References

@mikesposito mikesposito requested a review from a team as a code owner June 20, 2023 09:41
Gudahtt
Gudahtt approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito merged commit e263d07 into main Jun 20, 2023
@mikesposito mikesposito deleted the feat/keyring-destroy branch June 20, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the destroy method on Keyring type
2 participants
@mikesposito @Gudahtt