Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devdeps): @lavamoat/allow-scripts@^2.3.1->^3.0.4 #184

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 21, 2024

Security-related maintenance update.

Copy link

socket-security bot commented May 21, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@lavamoat/allow-scripts@3.0.4 environment Transitive: filesystem, network, shell, unsafe +60 3.62 MB boneskull
npm/glob@10.3.15 Transitive: environment, filesystem, shell +20 2.07 MB isaacs
npm/is-core-module@2.13.1 None 0 30.2 kB ljharb
npm/lru-cache@10.2.2 None 0 681 kB isaacs
npm/semver@7.6.2 None 0 95.4 kB npm-cli-ops
npm/socks@2.8.3 network +4 558 kB joshglazebrook

🚮 Removed packages: npm/@lavamoat/allow-scripts@2.3.1, npm/is-core-module@2.14.0, npm/semver@7.6.0

View full report↗︎

Copy link

socket-security bot commented May 21, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@npmcli/agent@2.2.2, npm/abbrev@2.0.0, npm/agent-base@7.1.1, npm/socks-proxy-agent@8.0.3, npm/validate-npm-package-name@5.0.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat added the dependencies Pull requests that update a dependency file label May 21, 2024
@legobeat legobeat marked this pull request as ready for review May 21, 2024 05:08
@legobeat legobeat requested a review from a team as a code owner May 21, 2024 05:08
@Gudahtt
Copy link
Member

Gudahtt commented Jul 12, 2024

@SocketSecurity ignore npm/socks-proxy-agent@8.0.3
@SocketSecurity ignore npm/agent-base@7.1.1
@SocketSecurity ignore npm/@npmcli/agent@2.2.2

These are all intended to have network access

@Gudahtt
Copy link
Member

Gudahtt commented Jul 12, 2024

@SocketSecurity ignore npm/abbrev@2.0.0
@SocketSecurity ignore npm/validate-npm-package-name@5.0.1

New authors look OK; one appears to be on the npm CLI team, the other is a bot operated by that team.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit c19a65e into MetaMask:main Jul 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants