Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9.0.0 #187

Closed
wants to merge 3 commits into from
Closed

9.0.0 #187

wants to merge 3 commits into from

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift self-assigned this May 30, 2024
@MajorLift MajorLift requested a review from a team as a code owner May 30, 2024 21:10
@MajorLift MajorLift changed the base branch from main to use-superstruct-fork May 30, 2024 21:10
@socket-security Socket Security
Copy link

socket-security bot commented May 30, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

@MajorLift MajorLift changed the title Release 9.0.0 9.0.0 May 30, 2024
mcmire
mcmire requested changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you might have to change the version, and also run yarn locally to update the lockfile.

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@metamask/utils",
"version": "8.4.0",
"version": "8.5.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 9.0.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "8.5.0",
"version": "9.0.0",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! The yarn run will need to wait until superstruct 3.0.0 is released.

@MajorLift MajorLift closed this Jun 4, 2024
@MajorLift MajorLift deleted the release/9.0.0 branch June 4, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire requested changes

Assignees

@MajorLift MajorLift

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use @metamask/superstruct, set moduleResolution to NodeNext
2 participants
@MajorLift @mcmire