chore: faster address validation #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nodonisko
force-pushed
the
chore/faster-hex-validation
branch
2 times, most recently
from
998f99a to
3606596
Compare
Nodonisko
force-pushed
the
chore/faster-hex-validation
branch
from
3606596 to
e358a03
Compare
4 tasks
Mrtenz
reviewed
Jul 1, 2025
Mrtenz
approved these changes
Jul 1, 2025
cryptodev-2s
pushed a commit
to MetaMask/core
that referenced
this pull request
Jul 3, 2025
## Explanation Address formatting and validation is used all across the app but these functions are not performant enough for mobile app se we need to use faster + memoized versions in order to improve mobile app performance. There shou ## References This PR needs to wait until MetaMask/utils#248 is merged and released. ## Changelog <!-- THIS SECTION IS NO LONGER NEEDED. The process for updating changelogs has changed. Please consult the "Updating changelogs" section of the Contributing doc for more. --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes --------- Co-authored-by: Charly Chevalier <charlyy.chevalier@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to refactor hex utils one more time because some validation function were also very slow. It looks that
superstructis more than 5x slower for simple RegExp validation. Even with native RegExp it still not fast enough so I also added memoizations.