Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init optional method to Keyring type #99

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

gantunesr
Copy link
Member

No description provided.

Copy link
Contributor

@danroc danroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note: in the future we may need to add an optional options parameter.

@gantunesr gantunesr merged commit ae5b0be into main Apr 19, 2023
@gantunesr gantunesr deleted the fix/keyring-type branch April 19, 2023 20:20
legobeat pushed a commit that referenced this pull request Apr 25, 2023
### Changed
- The `Keyring` exposes a new optional method `init` ([#99](#99))

### Fixed
- Bump `@ethereumjs/tx` to `4.1.2` to address runtime compatibility issues ([#100](#100))
mcmire pushed a commit to mcmire/core that referenced this pull request Jul 17, 2023
### Changed
- The `Keyring` exposes a new optional method `init` ([MetaMask#99](MetaMask/utils#99))

### Fixed
- Bump `@ethereumjs/tx` to `4.1.2` to address runtime compatibility issues ([MetaMask#100](MetaMask/utils#100))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants