This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Use hex strings for filter block handler indices #155 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the numeric index `self.filterIndex` results in problems later on when we try to uninstall handler.
danfinlay
reviewed
May 31, 2017
| var hexFilterIndex = intToHex(self.filterIndex) | ||
| self.asyncBlockHandlers[hexFilterIndex] = blockHandler |
There was a problem hiding this comment.
Ahh, now I see what you meant!
danfinlay
approved these changes
May 31, 2017
|
Oh right, our CI doesn't run foreign branch PRs. I'll run this and merge if it passes after dinner. Thanks again! |
|
Interesting note to our team: Pushing up his branch onto the upstream remote triggered the test suite on the same PR! That's convenient. |
|
Published in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the numeric index
self.filterIndexresults in problemslater on when we try to uninstall handler.