Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding multiple entity-replacements tokens in a single value #162

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Allow adding multiple entity-replacements tokens in a single value #162

merged 5 commits into from
Nov 7, 2023

Conversation

Esrohym
Copy link
Member

@Esrohym Esrohym commented Apr 5, 2023

No description provided.

@Esrohym Esrohym linked an issue Apr 5, 2023 that may be closed by this pull request
Allow adding multiple entity-replacement tokens in a single value #163
Closed
omarlopesino
omarlopesino requested changes Apr 5, 2023
View reviewed changes
Copy link
Member

@omarlopesino omarlopesino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the comments and do the respective fixes, specially the fixes proposed to solve the possible PHP warnings

@omarlopesino omarlopesino changed the title Allow adding multiple entity-replacements tokens in a single value #163 Allow adding multiple entity-replacements tokens in a single value Apr 10, 2023
@omarlopesino omarlopesino changed the title #163 Allow adding multiple entity-replacements tokens in a single value Allow adding multiple entity-replacements tokens in a single value Apr 10, 2023
@omarlopesino
Copy link
Member

Rel #163

@Metadrop Metadrop deleted a comment from Esrohym Apr 10, 2023
@omarlopesino
Copy link
Member

I've requested one more change. With that, I can merge.

@omarlopesino
Copy link
Member

Reviewed and tested. I confirm it has backwards compatibility, however i excluded it from documentation so we may discard it in a future. Merging, thanks!

@omarlopesino omarlopesino merged commit 3e937ea into master Nov 7, 2023
@omarlopesino omarlopesino deleted the feature/entity-replacement-multiple branch November 7, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omarlopesino omarlopesino omarlopesino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow adding multiple entity-replacement tokens in a single value
2 participants
@Esrohym @omarlopesino