Skip to content

Commit

Permalink
Merge branch 'master' of ssh://github.com/MetalBlueberry/go-plotly
Browse files Browse the repository at this point in the history
  • Loading branch information
MetalBlueberry committed May 14, 2020
2 parents 460c150 + 3fa2af4 commit e3a4e23
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ package main

import (
grob "github.com/MetalBlueberry/go-plotly/graph_objects"
"github.com/MetalBlueberry/go-plotly/plotly"
"github.com/MetalBlueberry/go-plotly/offline"
)

func main() {
Expand Down Expand Up @@ -107,4 +107,4 @@ For bool, the solution is as simple as defining the types again inside graph_obj

For strings... This is a little bit more complicated, In AWS package they are using `aws.String` which maps to `*string` to workaround this issue, but I find that really annoying because you have to wrap every single string with `aws.String("whatever")`. For now I've decided to define the type String but leave it as `interface{}` instead of `*string` to allow you to use raw strings. The draw back is that you can pass any value of your choice... Hopefully you can live with this :).

For numbers... It's similar to strings, Right now you cannot create plots with integer/float numbers with 0 value. I've only encounter problems when trying to remove the margin and can be workaround with an small value like `0.001`. I would like to avoid using interface{} or defining types again to keep the package interface as simple as possible.
For numbers... It's similar to strings, Right now you cannot create plots with integer/float numbers with 0 value. I've only encounter problems when trying to remove the margin and can be workaround with an small value like `0.001`. I would like to avoid using interface{} or defining types again to keep the package interface as simple as possible.

0 comments on commit e3a4e23

Please sign in to comment.