Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyPI publication by updating snowflake-connector-python #657

Merged

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Nov 3, 2023

🤔 Why?

We were unable to publish to PyPI due to the workaround suggested by wbond/oscrypto#78 (comment).

🤓 What?

Now that the latest version of https://github.com/snowflakedb/snowflake-connector-python has moved away from oscrypt, we can simply update and remove the workaround.

🧪 Tested?

Verified against a production instance.

Copy link

This pull request has been linked to Shortcut Story #21491: Unable to publish to PyPI due to oscrypto.

@mars-lan mars-lan enabled auto-merge (squash) November 3, 2023 00:41
Copy link

github-actions bot commented Nov 3, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12493 11301 90% 85% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 49ba0be by action🐍

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 31 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@alyiwang alyiwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!
Thanks for the fix

@mars-lan mars-lan merged commit 430adec into main Nov 3, 2023
6 checks passed
@mars-lan mars-lan deleted the marslan/sc-21491/unable-to-publish-to-pypi-due-to-oscrypto branch November 3, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants