Skip to content

Commit

Permalink
Prevent syncd from stopping swss in the presence of SAI failures in s…
Browse files Browse the repository at this point in the history
…ynchronous mode (sonic-net#653)

* Prevent syncd from stopping swss in the presence of SAI failures in synchronous mode

* Remove TODO message

* Update log message
  • Loading branch information
shi-su authored Aug 31, 2020
1 parent c4a86b3 commit 9c80626
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions syncd/Syncd.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1244,16 +1244,7 @@ void Syncd::sendApiResponse(

if (status != SAI_STATUS_SUCCESS)
{
/*
* TODO: If api fill fail in sync mode, we need to take some actions to
* handle that, and those are not trivial tasks:
*
* - in case create fail, remove object from redis database
* - in case remove fail, bring back removed object to database
* - in case set fail, bring back previous value if it was set
*/

SWSS_LOG_THROW("api %s failed in syncd mode: %s, FIXME",
SWSS_LOG_ERROR("api %s failed in syncd mode: %s",
sai_serialize_common_api(api).c_str(),
sai_serialize_status(status).c_str());
}
Expand Down

0 comments on commit 9c80626

Please sign in to comment.