Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMAROC-848 update contribution guidelines / citation file #143

Merged

Conversation

regDaniel
Copy link
Collaborator

@regDaniel regDaniel commented Sep 4, 2024

Description:

Please add a brief summary of what this PR does.

Error(s) fixed:

Please tag them using #, e.g. Fixed #42.

Checklists:

  • New code includes dedicated tests.
  • New code has been linted.
  • New code follows the project's style.
  • New code is compatible with the 3-Clause BSD license.
  • CHANGELOG has been updated.
  • AUTHORS has been updated.
  • Copyright years in module docstrings have been updated.

CONTRIBUTING.md Show resolved Hide resolved
Copy link
Member

@fpavogt fpavogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug in the Sphinx docs: https://meteoswiss.github.io/ampycloud/changes.html

The link to the changelog is not set properly. Should be `changelog <changelog>`_ (there's a _ missing).

Also, the bullet points do not show up properly - you need to add en empty line before and after them (you can test the fix directly on Github without any commit, if unsure ...).

@regDaniel regDaniel merged commit e781ef0 into develop Sep 5, 2024
14 checks passed
@regDaniel regDaniel deleted the feature/AMAROC-848-update-contribution-citation-authors branch September 5, 2024 07:07
regDaniel added a commit that referenced this pull request Oct 14, 2024
* Add manual trigger for pypi release

* Update copyright in tag

* Upate citatiuon details

* Fix typo

* Fix format of CITATION.cff

* Amaroc 841 localized base height calculation (#137)

* AMAROC-835 add ceilo id query for base height calculation

* AMAROC-835 request minimum amount of hits for base height calculation

* AMAROC-841 localized cloud base height calculation

* AMAROC-842 resolve version conflict

* AMAROC-841 AMAROC-842 adapt changelog

* AMAROC-841 raise warning if we do not filter but filter is set + adapt test

* AMAROC-841 add documentation

* AMAROC-841 fix doc referencing

* AMAROC-841 exclude instead of keep ceilos (#140)

* AMAROC-847 Set new release version (#141)

* AMAROC-848 update contribution guidelines / citation file (#143)

* AMAROC-848 update contribution guidelines / citation file

* AMAROC-848 update changelog

* AMAROC-848 fix doc reference

* AMAROC-848 fix bullet list

* AMAROC-845 require statsmodels minimum 0.14.3 (#144)

* AMAROC-863 set next patch version

---------

Co-authored-by: Frédéric P.A. Vogt <13974615+fpavogt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants