Support latest browser versions #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppeteer driverpuppeteer v19.x is the latest compatible version with node 14.x (the version Meteor 2.x requires to run) Any version above will trigger an error on install it. Also, I used the option required to skip the warning:
|
Playwright driverPlaywright v1.33.x is the latest compatible version with node 14.x (the version Meteor 2.x requires to run). I also added documentation for this driver usage.
|
|
All drivers supported has been reviewed on this PR. This is ready for review and merge. |
StorytellerCZ
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Great job @nachocodoner, thanks a lot!
I will merge and release this as a patch release.
I think we can also start a new branch for Meteor 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightmare/Electron driver
Nightmare browser driver is working straight with latest version (
^3.0.2). However, there, was an annoying warning around CSP, which I disabled it, since this is a test environment, not a production one, and we don't need to care about those securities issues.