Update deps and expand test suite #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Honestly we should drop support for Meteor 1 series. |
|
@StorytellerCZ Fine by me, drop them |
harryadel
approved these changes
Sep 23, 2024
|
I think what we can say that it is depracated (still will have the version resolution, but not tests) and as of next major it will be dropped in all forms. |
jankapunkt
approved these changes
Sep 23, 2024
|
The 1.x tests take ages.... |
|
@jankapunkt it looks like they won't run the client tests. |
For some reason the client tests were not running and Meteor 1 is deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update simple-schema and eventemitter version rangers.
Do the same for mocha in testing and experiment with adding more versions for testing.