Fixes for devEnvSetup.js #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
@dd137 thank you for this PR. I think this is a general improvement over the existing situation, so unless you still want to add something I would like to merge this and then continue on from there. |
|
Changed the target towards the fix branch. |
|
@dd137 do you want to do anything more here. |
|
@StorytellerCZ Thanks. I realized test-integration is missing from devEnvSetup.js. I'll add that with one more commit then I'm done here. |
Section probably shouldn't be in Prerequisites Add explicit add-platform command instead of a comment about it Clarify when the scaffold command is used and what it does Fix spaces / line returns
dd137
force-pushed
the
fix/devEnvSetup
branch
from
076950a
to
243fca0
Compare
dd137
force-pushed
the
fix/devEnvSetup
branch
from
932dada
to
1f6eeaf
Compare
|
@StorytellerCZ Feel free to review and merge this PR. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script crashes due to
The script also ignores the user's answer about whether to run tests or not (it always runs them, possibly after executing
finish()). For convenience, it would also be nice to know what are the default answers to the script's questions.This PR addresses these small problems, along with a rewrite of the related README section about "Developing meteor-desktop" and using devEnvSetup.
Note: The last two tests run by devEnvSetup,
npm run desktop -- build -bandnpm run test-desktopin meteor-desktop-test-app also fail, but I don't think this is caused by devEnvSetup itself and therefore is not addressed by this PR.Tested with meteor-desktop 3.1.0.