Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devrton: Remove all usage of and references to the obsolete package #27

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

dd137
Copy link

@dd137 dd137 commented Sep 28, 2023

As per title.

Note that I removed the following point from README -> desktopHCP -> Caveats:

if your run a production build of your desktop app it will not receive updates from project run
from meteor command unless you run it with --production - that is because development build
has devtron added and therefore the compatibilityVersion is different

The reason is that 1) the "issue" still seems to happen after removal of devrton (?) and 2) running meteor with --production doesn't work for me either, because changes in .desktop/ do not trigger a desktopHCP reload anyway. So it seems to me that this comment is outdated, but I may be wrong. Feel free to add a corrected text if applicable.

Copy link
Member

@StorytellerCZ StorytellerCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just need to figure out if this should go into a patch release or at least a minor release. Given that we are removing something, according to semantic versioning we should have a major version bump, but I think we can get away with just a minor version bump. What do you think?

@StorytellerCZ
Copy link
Member

As per #24 I'm merging this in for testing.

@StorytellerCZ StorytellerCZ merged commit 194b563 into fix/bug-12 Sep 29, 2023
@StorytellerCZ StorytellerCZ deleted the fix/remove-devtron branch September 29, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants