All published records removed and re-added on subsequent subscriptions in 1.7.1

[sean-kates]

Hi there,

Seems to be that in the most recent update (1.7.0 -> 1.7.1), the publication behavior changed somewhat significantly. Not positive if it is intended, I certainly didn't expect it.

We use publish-composite for a list of items that a user can scroll through, sorted by some field. We pass the subscription a limit (lets say 25 items), and once the user reaches the bottom of the list, they click "Load More", which bumps the limit up to 50, and re-subscribes with the new limit.

In 1.7.0, the re-subscription just published the next 25 items in the list since the first 25 are already published. In 1.7.1, the re-subscription actually removes all the currently published items, and then publishes the 50 items.

This is a problem for the pagination since the user all of a sudden has no items in their view, which scrolls them up to the top of the page, and then once the 50 items are published, they have to scroll all the way back down to where they were before.

Thanks!

[yched]

We're also seeing unintended behavior changes after 1.7.1 and #121.

In our case this happens when a user logs in - when that happens, it seems Meteor stops and immediately restarts all existing subscriptions (composite and "regular" ones).
For documents published by regular, non-composite publications, this is transparent, causing no actual DDP activity.
For composite publications, this was transparent too until 1.7.0.
In 1.7.1, the documents returned by the top-level 'find' in each composite subscription get removed and readded over DDP, causing UI flickering and the loss of scroll position due to the unmounting / remounting of the corresponding DOM nodes.

[reywood]

I have reverted the previous changes and released a new version. Let me know if this fixes the problem.

[yched]

@reywood works perfectly, thanks a lot for the quick fix !

[sean-kates]

Works great! Appreciate the fix.