Handle stopping a publication early #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This caused unintended behavior changes, see #124 For now we had to lock to 1.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered a situation where if you subscribe to a huge publication, or any-sized publication really, and you want to stop it early, the publication won't stop until all the cursors have finished running (i.e.
onStopdoesn't get called until the cursors have returned). This PR allows theonStopto be called immediately in order to stop the cursors. This PR potentially fixes other issues people are having that they may have perceived as a performance issue.The code on
publication.jsisn't so great but it works. I am open for someone to clean that up so it isn't so terrible.