Add FCM Firebase Cloud Messaging support #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fishsaidno looks good so far - just remove comments / unused code - ping me if you want me to review |
Open
|
@fishsaidno any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a WIP, opening this PR for code review, suggestions and and testing.
With my testing so far, it seems pretty solid, however I have not yet tested in a production-like environment.
Have not yet implemented webpush (desktop notifications) using FCM, this PR only focuses on cordova integration.
Documentation still needs a lot of work, docs/FCM.md is a quick overview of the changes.
Most of that should probably be edited into the existing documentation.
Will update this further next week.
Cheers!