Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/remove individual values instead of changing the whole list setting #2795

Closed
wants to merge 1 commit into from

Conversation

sbxte
Copy link
Collaborator

@sbxte sbxte commented Sep 27, 2022

Closes #418

@MineGame159
Copy link
Member

I don't like how you made the "toggle" behaviour be the default. It goes against how every other setting works and IMO this should be done with sub commands like the issue says.

Also I am not a big fan of not creating a new ArrayList in the parse methods because they should not modify the current state of the setting as the caller is responsible for actually setting the value or rejecting the new value. But I guess it is fine because that can never happen with those settings.

@sbxte
Copy link
Collaborator Author

sbxte commented Sep 27, 2022

Hmm. Guess I'll rewrite it with command argument builder instead.

@sbxte sbxte marked this pull request as draft September 27, 2022 21:20
@sbxte sbxte closed this Sep 28, 2022
@sbxte sbxte deleted the listsetting-parseimpl branch September 28, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] List setting command improvements
2 participants