Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highway builder: baritone pathing #5254

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hexadec1mal
Copy link

Type of change

  • Bug fix
  • New feature

Description

Now, pathing, breaking, and placing don't depend on the player's position. Collecting shulkers and obsidian is now also done using baritone, so blockade states have been removed. I was rewriting some parts of the code, so I might have deleted something important. If you have any questions about my code, please ask.

Related issues

None.

How Has This Been Tested?

Will test properly later, after review. And I will probably change something else, so making this draft for now.

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@Wide-Cat
Copy link
Collaborator

I have some local changes regarding highway builder that I want to clean up and commit before examining something like this. I haven't tested this yet but I skimmed the code, and I don't really like the fact that the module now requires baritone to be added in order to be used. If this were to be added I think it should be optional for it to use baritone.

How does the module perform using baritone compared to without? Is it faster/slower, or more reliable? There are a couple of small issues with the module as it stands, but from my testing it's very stable overall, so I can't say with certainty if using baritone comes with more benefits that not yet. I'll test it on my own after I finish my local changes but I want to hear your perspective.

@hexadec1mal
Copy link
Author

It's faster now because it can break/place and move simultaneously.

These changes
image
prevent moving away from the starting direction, so it should be more stable now.

In hwu discord, I saw people saying that they lose obsidian when mining ender chests. I have never seen this myself, but since baritone now collects obsidian, it shouldn't happen anymore.

Making baritone optional requires 2 versions of the module, which can't be consistently kept in sync, so I don't think that's an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants