Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Description for Azure RMService Connection #516

Conversation

arturopolanco
Copy link
Contributor

PR Summary

Description field is added to the "Add-VSTeamAzureRMServiceEndpoint" cmdlet. As it is already part of the AzDo API is enough to add it to the JSON object and parse it to "Add-VSTeamServiceEndpoint"

PR Checklist

@SebastianSchuetze
Copy link
Collaborator

@arturopolanco somehow the reference is not found when running unit tests on Ubuntu.

@SebastianSchuetze
Copy link
Collaborator

Also please update the version in the psd1 file.

@arturopolanco arturopolanco marked this pull request as draft April 18, 2023 08:11
@arturopolanco arturopolanco marked this pull request as ready for review April 18, 2023 08:17
@arturopolanco
Copy link
Contributor Author

@arturopolanco somehow the reference is not found when running unit tests on Ubuntu.

Hey Sebastian, there was a wrong reference, I should work now. let me know how it goes

@SebastianSchuetze SebastianSchuetze self-requested a review April 18, 2023 13:26
Copy link
Collaborator

@SebastianSchuetze SebastianSchuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all fine. I can merge!

@SebastianSchuetze SebastianSchuetze merged commit e8be72c into MethodsAndPractices:trunk Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants