Skip to content
This repository has been archived by the owner on Jan 1, 2024. It is now read-only.

fix: root is now rendered only once #202

Merged
merged 1 commit into from
Mar 25, 2018

Conversation

Grimones
Copy link
Contributor

Before, there was only fix for dispatching APPLICATION_INIT once. However Root component was rendered twice. initAlready wasn't working as expected.

Proof.

This PR fixes this behaviour by updating the react-async-bootstrapper. react-async-bootstrapper has been updated to v2.1.0 which added an ability to expose bootstrapper context to components.

Now <Root /> renders only once.

Based on this issue

@codecov
Copy link

codecov bot commented Mar 25, 2018

Codecov Report

Merging #202 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files          10       10           
  Lines          55       55           
  Branches        5        5           
=======================================
  Hits           53       53           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82d321e...c43aa5e. Read the comment docs.

@Metnew
Copy link
Owner

Metnew commented Mar 25, 2018

Awesome, thanks!

@Metnew Metnew merged commit a5e0bf4 into Metnew:master Mar 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants