This repository has been archived by the owner on Jan 1, 2024. It is now read-only.
fix: webpack server config will omit image output #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits the url-loader rule into the client and server configs with the only difference being whether the file is emitted by webpack or not. In the server rendered page, src tags will be correctly filled in.
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 10 10
Lines 55 55
Branches 5 5
=======================================
Hits 53 53
Misses 2 2Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the
url-loaderrule into the client and server configs with the only difference being whether the file is emitted by webpack or not. In the server rendered page,srctags will still have the correct file path.