MetronInfo Support #119
Merged
MetronInfo Support #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache the ET.SubElement function, so we aren't repeatedly looking up the function. Make some of the loops more efficient
- Use get method for dictionary lookups - Simplify some loops with a dictionary mapping
This was removed from the schema
If fails validation raise an XmlError Removed the attributes from `_get_root` until finalized schema so that we validate
Not really necessary since we validate before writing to file.
Add `issue_count` and `volume_count` to Series dataclass since they describe the Series
Also update to latest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for MetronInfo.xml