Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limitation percentage values are not consistent #143

Closed
MiSchroe opened this issue Jul 4, 2024 · 0 comments · Fixed by #144
Closed

Limitation percentage values are not consistent #143

MiSchroe opened this issue Jul 4, 2024 · 0 comments · Fixed by #144
Assignees
@MiSchroe

Comments

@MiSchroe
Copy link
Owner

MiSchroe commented Jul 4, 2024

The calculated percentage values for the limitatations of a product are not consistent. They depend on the getLimitation method which sorts the min and max values by their size. Instead, the min value should always refer to the raw min value and the same for the max values.
@MiSchroe MiSchroe self-assigned this Jul 4, 2024
@MiSchroe MiSchroe mentioned this issue Jul 4, 2024
Merged
MiSchroe pushed a commit that referenced this issue Jul 4, 2024
chore: release v4.1.3
8b0ec17 
-   [#143](#143) Fix unconsistent min/max limitation values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MiSchroe MiSchroe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limitation percentage values are not consistent MiSchroe/klf-200-api
1 participant
@MiSchroe