Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend interfaces to let the user provide additional parameters that are defaulted currently #41

Closed
MiSchroe opened this issue Nov 2, 2021 · 0 comments · Fixed by #49
Closed

Extend interfaces to let the user provide additional parameters that are defaulted currently #41

MiSchroe opened this issue Nov 2, 2021 · 0 comments · Fixed by #49
Assignees
@MiSchroe
Labels
enhancement

Comments

@MiSchroe
Copy link
Owner

MiSchroe commented Nov 2, 2021

E.g. the runAsync() method in the scenes class could be enhanced to provide additional parameters that are defaulted at the moment. By this change it would be possible to run a scene at another speed (e.g. in silent mode).

All methods should be enhanced like this. To prevent breaking current using the parameters should be defaulted to the same values that are used to call the KLF200.
@MiSchroe MiSchroe self-assigned this Nov 2, 2021
@MiSchroe MiSchroe linked a pull request Dec 1, 2021 that will close this issue
Merge pull request #48 from MiSchroe/MiSchroe/issue47 #49
Merged
@MiSchroe MiSchroe closed this as completed Dec 1, 2021
MiSchroe added a commit that referenced this issue Dec 2, 2021
@MiSchroe
chore: release v3.1.0
fc25364 
### Enhancements:

* [#24](#24) Add `refreshScenes()` method to re-read scenes data from the gateway
* [#27](#27) Add `refresh()` method to re-read object data from the gateway
* [#28](#28) Add methods and properties for product limitations.
* [#41](#41) Add additional default parameters to methods.
* [#50](#50) Add handler to log frames that are sent to the KLF 200.

### Fixes:

* Fix security audit dependencies ([#32](#32), [#35](#35), [#37](#37))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MiSchroe MiSchroe

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge pull request #48 from MiSchroe/MiSchroe/issue47 MiSchroe/klf-200-api
1 participant
@MiSchroe