Stop using Apt class to avoid duplicate declaration and use conf.d file to make Apt use the proxy #11
Conversation
…le to make Apt use the proxy
|
can you remove the apt module dependency here: https://github.com/MiamiOH/puppet-httpproxy/blob/master/metadata.json#L24 |
| }, | ||
| file { 'apt_via_proxy': | ||
| ensure => $httpproxy::packagemanager::ensure, | ||
| path => '/etc/apt/apt.conf.d/05proxy', |
There was a problem hiding this comment.
https://github.com/puppetlabs/puppetlabs-apt/blob/v7.1.0/manifests/init.pp#L194
I suggest /etc/apt/apt.conf.d/01proxy so that we don't end up with 2 files when converting and maintain backwards compatability
| owner => 'root', | ||
| group => 'root', | ||
| mode => '0644', | ||
| content => "Acquire::http::Proxy \"http://${httpproxy::http_proxy}:${httpproxy::http_proxy_port}\";", | ||
| } |
There was a problem hiding this comment.
The old way also does an apt::update: https://github.com/puppetlabs/puppetlabs-apt/blob/main/manifests/setting.pp#L63
Are we ok with losing that functionality?
| owner => 'root', | ||
| group => 'root', | ||
| mode => '0644', | ||
| content => "Acquire::http::Proxy \"http://${httpproxy::http_proxy}:${httpproxy::http_proxy_port}\";", |
There was a problem hiding this comment.
https://github.com/puppetlabs/puppetlabs-apt/blob/v7.1.0/templates/proxy.epp#L2
Acquire::http::proxy
DOn't know if case matters here
No description provided.