Wait for GHA eval results instead of falling back to local evaluation #451
+45
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should silence the warning:
|
|
This implementation is quite naive. We could eventually wait within the function and thus not restarting the fetching process from scratch each time. |
Mic92
reviewed
Jan 5, 2025
Mic92
reviewed
Jan 5, 2025
I removed them all. Do you have a better idea ? |
Mic92
reviewed
Jan 5, 2025
GaetanLepage
force-pushed
the
wait
branch
4 times, most recently
from
471bd4f to
0247365
Compare
GaetanLepage
commented
Jan 5, 2025
Mic92
reviewed
Jan 5, 2025
|
I confirm that printing is fixed: |
|
Should we add a tip: |
GaetanLepage
force-pushed
the
wait
branch
3 times, most recently
from
028f616 to
be1b1e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default evaluation mode (
github) attempts at fetching the evaluation results from the GitHub actions result.Those will only be available a few minutes after the PR has been opened as they are not trivial to compute.
Currently, if the results are not available right away,
nixpkgs-reviewfalls back to local evaluation.This PR changes this behavior. Now it will keep re-trying until the results are available.
Note: It is still possible to force local evaluation by using
--eval local.Motivation: Local evaluation is very resource-intensive (especially RAM). It should be an opt-in behavior.
This new approach is more predictable.
Questions:
-> I have set a maximum waiting time of 10min:
HandleCtrl-Ccorrectly (i.e. properly delete the worktree on exit)-> There is no worktree at this point. Just quit gracefully.