Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken link to sops readme heading #564

Closed
wants to merge 2 commits into from
Closed

Fixed broken link to sops readme heading #564

wants to merge 2 commits into from

Conversation

ginkogruen
Copy link

I noticed the link wasn't linking to the heading correctly so I fixed it.
Apparently it had changed again.

@dasJ
Copy link
Collaborator

dasJ commented May 23, 2024

@mergify queue

Copy link
Contributor

mergify bot commented May 23, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@ginkogruen
Copy link
Author

It seems mergify-bot has some sort of hiccup (or permission error if I'm reading correctly). Could someone take a look at this?

@Mic92
Copy link
Owner

Mic92 commented May 24, 2024

Looks like it doesn't work because you didn't allow maintainers to make changes to your feature branch.

@ginkogruen
Copy link
Author

ginkogruen commented May 24, 2024

That's the checkmark below the participants on here right? It was checked the whole time. I going to try unchecking and rechecking that.

2024-05-24T23:48:37,024416892+02:00

If there are any other options I need to check/uncheck I would be grateful for some pointers. To my knowledge I didn't change anything and kept things default.

@ginkogruen
Copy link
Author

So I've accidentally synced my fork. I thought this might change some permission things about mergify but in hindsight I'm not too sure about that.

I still would like to get this merged. Is it still possible with the synced fork?
Also maybe the permissions did change after I unchecked and re-checked the box.

So If there aren't any other setting I need to check maybe mergify would work this time.
Otherwise I think it may be better If someone else who understands mergify and GitHub does the commit.

@@ -189,7 +189,7 @@ uid [ unknown] root <root@localhost>
The fingerprint here is `9F89C5F69A10281A835014B09C3DC61F752087EF`.
</details>

Your `age` public key or GPG fingerprint can be written to your [`.sops.yaml`](https://github.com/getsops/sops#using-sops-yaml-conf-to-select-kms-pgp-and-age-for-new-files) in the root of your configuration directory or repository:
Your `age` public key or GPG fingerprint can be written to your [`.sops.yaml`](https://github.com/getsops/sops#using-sopsyaml-conf-to-select-kms-pgp-and-age-for-new-files) in the root of your configuration directory or repository:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I can confirm the old link seems to be working again. I did some digging around and it seems that GitHub changed how they render .rst documents which caused some things (including the Table of Contents) to not render correctly.
I guess this changed some of the heading links too.

For reference:

@ginkogruen ginkogruen closed this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants