-
-
Notifications
You must be signed in to change notification settings - Fork 145
PR for Duplicated UDP responses from DNS confuse LookupClient #140 #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @JamesKovacs The unit test, especially |
MichaCo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Just 2 minor things
test/DnsClient.Tests/LookupTest.cs
Outdated
| [InlineData(0, false)] | ||
| [InlineData(1, false)] | ||
| [InlineData(3, false)] | ||
| [InlineData(10, false)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [InlineData(10, false)] | |
| //[InlineData(10, false)] |
test/DnsClient.Tests/LookupTest.cs
Outdated
| [InlineData(0, true)] | ||
| [InlineData(1, true)] | ||
| [InlineData(3, true)] | ||
| [InlineData(10, true)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [InlineData(10, true)] | |
| //[InlineData(10, true)] |
Not sure why those 2 variants fail, at least when run under .NET47x.
Let's just comment it out for now?
|
Thanks for the feedback. I've addressed your comments and will push another commit to the branch shortly. |
|
Changes pushed and ready for review. Thanks again! |
|
The tests failed during build. I'll fix that later, seems not really related to your changes. Thanks again for your help! |
|
@MichaCo Looking forward to the new version. We have been seeing DNS resolution failure in one of our cluster from time to time but was not able to identity the root cause, thanks @JamesKovacs ! |
The following PR is to resolve the issue reported in #140.