Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File DietPi-Docs_Todo.md added #61

Merged
merged 5 commits into from
Oct 9, 2020
Merged

File DietPi-Docs_Todo.md added #61

merged 5 commits into from
Oct 9, 2020

Conversation

StephanStS
Copy link
Collaborator

DietPi-Docs_Todo.md is a working draft to define the next steps:

  • Restructuring issues
  • Docu style guide issues
  • Next changes

@StephanStS StephanStS requested review from fpetru and MichaIng October 9, 2020 08:04
@StephanStS
Copy link
Collaborator Author

@MichaIng, @fpetru: I added you as reviewers to test whether this is the right way we should act when committing to dev branch. Depending on the issue also no reviewer (e.g. typos) or only one reviewer (to fulfil a 4 eyes principle) might be enought.

@MichaIng
Copy link
Owner

MichaIng commented Oct 9, 2020

Great. I made the master branch a protected branch where any pull request requires at least one approved review before it can be merged.

Shall I add a simple method to test the current dev branch or even a choosable owner/branch directly on our server, e.g. dietpi.com/testdocs or similar? This would allow us to test as well the build, so that no Python module is missing and/or no incompatible version installed and possibly webserver related issues. That URL needs to be added to site crawler exclusion (robots.txt) and to Cloudflare cache exclusion. We might even want to add an authentication method to access the testing site.
Uploading/building to that test URL could be as well to allow final test before merging into master, as part of the review procedure?

@fpetru fpetru merged commit 92b314b into MichaIng:dev Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants