Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Survey | Cleanup: Remove survey version and sent count from upload file #2626

Merged
merged 3 commits into from
Mar 10, 2019

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Mar 9, 2019

Status: Ready

  • DietPi-Patch
  • DietPi-Survey_report

Commit list/description:

  • DietPi-Survey | Cleanup: Remove survey version and sent count from upload file. We handle added/removed entries via array sourcing automatically, otherwise can derive this from DietPi version. Sent count is of minor interest and simply overloads the report page, especially when we want to introduce optional regular (weekly or monthly) uploads in future versions.
  • DietPi-Survey | Minor coding

+ DietPi-Survey | Cleanup: Remove survey version and sent count from upload file. We handle added/removed entries via array sourcing automatically, otherwise can derive this from DietPi version. Sent count is of minor interest and simply overloads the report page, especially when we want to introduce optional regular (weekly or monthly) uploads in future versions.
+ DietPi-Survey | Minor coding
@MichaIng MichaIng added Enhancement 💨 META Everything that is not code related, e.g. GitHub, Wiki, website, community labels Mar 9, 2019
@MichaIng MichaIng added this to the v6.22 milestone Mar 9, 2019
@MichaIng MichaIng self-assigned this Mar 9, 2019
+ DietPi-Patch | DietPi-Survey: Remove survey sent count from settings file
…d sent count handling

+ Pre-v6.14 systems cannot upload to ssh.dietpi.com which was required post new yeah 2019
+ Survey version and sent count has been removed from upload files with v6.22
@MichaIng MichaIng merged commit 2d858a6 into dev Mar 10, 2019
@MichaIng MichaIng deleted the survey branch March 10, 2019 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💨 META Everything that is not code related, e.g. GitHub, Wiki, website, community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant