-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta v6.31.0 #3621
Merged
Beta v6.31.0 #3621
Commits on May 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5e8a44f - Browse repository at this point
Copy the full SHA 5e8a44fView commit details -
+ DietPi-Software | Code fixes and enhancements, based on CodeFactor scan
Configuration menu - View commit details
-
Copy full SHA for 5bf266e - Browse repository at this point
Copy the full SHA 5bf266eView commit details -
+ DietPi-Patch | Minor code enhancements based on CodeFactor scan
Configuration menu - View commit details
-
Copy full SHA for 57ef2a9 - Browse repository at this point
Copy the full SHA 57ef2a9View commit details
Commits on May 11, 2020
-
+ DietPi-Boot | Run network time sync before estimating network details. Waiting for network only checks for a default route, but especially in case of DHCP this can be present before a valid IP has been assigned. Network time sync is done anyway and, if not a local NTP server or custom method has been chosen, serves as an additional prove for internet connectivity. The non-interactive DietPi-Run_NTPD call does not require or use /run/dietpi/.network at all, hence no regression is implied. All services which require internet connectivity, especially those which read /run/dietpi/.network, should start "After=dietpi-boot.service", those which read /run/dietpi/.network additionally should call "ExecStartPre=/boot/dietpi/func/obtain_network_details" to have updated network info, e.g. on service restarts (ToDo).
Configuration menu - View commit details
-
Copy full SHA for 7fb8b09 - Browse repository at this point
Copy the full SHA 7fb8b09View commit details -
+ DietPi-Software | GMediaRender/WireGuard: Update network info before reading info file on service start. This prevents invalid IP info if DHCP lease on boot finishes before obtain_network_details is called or if during session the device is connected to a different network or DHCP applies a new IP and services are (re)started afterwards. Planned long-term solution is a set of functions to read network info directly from system instead of relying on correct /run/dietpi/.network content (ToDo).
Configuration menu - View commit details
-
Copy full SHA for e5fc3bb - Browse repository at this point
Copy the full SHA e5fc3bbView commit details -
+ CHANGELOG | Add v6.31 changelog + CHANGELOG | GMediaRender+WireGuard: Resolved an issue where service start could have failed due to invalid network information. Many thanks to @fnsnyc for reporting this issue: #3519 + CHANGELOG | After travelling back to the future 2030, we were able to apply bug fixes with alien technology to the v6.30 release back in 2020.
Configuration menu - View commit details
-
Copy full SHA for 9633e71 - Browse repository at this point
Copy the full SHA 9633e71View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3231a2 - Browse repository at this point
Copy the full SHA d3231a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66039a2 - Browse repository at this point
Copy the full SHA 66039a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16ec16e - Browse repository at this point
Copy the full SHA 16ec16eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20a9d33 - Browse repository at this point
Copy the full SHA 20a9d33View commit details -
Configuration menu - View commit details
-
Copy full SHA for b793f20 - Browse repository at this point
Copy the full SHA b793f20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ad6f8a - Browse repository at this point
Copy the full SHA 6ad6f8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5db997 - Browse repository at this point
Copy the full SHA e5db997View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ce5678 - Browse repository at this point
Copy the full SHA 3ce5678View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1f44ac - Browse repository at this point
Copy the full SHA b1f44acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 957a933 - Browse repository at this point
Copy the full SHA 957a933View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2bfe60 - Browse repository at this point
Copy the full SHA a2bfe60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3640909 - Browse repository at this point
Copy the full SHA 3640909View commit details -
Configuration menu - View commit details
-
Copy full SHA for 848784d - Browse repository at this point
Copy the full SHA 848784dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d541ee - Browse repository at this point
Copy the full SHA 1d541eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 338e689 - Browse repository at this point
Copy the full SHA 338e689View commit details -
Configuration menu - View commit details
-
Copy full SHA for c202885 - Browse repository at this point
Copy the full SHA c202885View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2eefa96 - Browse repository at this point
Copy the full SHA 2eefa96View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc062f0 - Browse repository at this point
Copy the full SHA dc062f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea0e202 - Browse repository at this point
Copy the full SHA ea0e202View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8a5148 - Browse repository at this point
Copy the full SHA e8a5148View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51089c8 - Browse repository at this point
Copy the full SHA 51089c8View commit details
Commits on May 12, 2020
-
+ DietPi-Software | Always call curl with "-f" option to have it exiting with error code and meaningful short error message in case of webserver error responses, instead of printing the HTML error page with exit code zero.
Configuration menu - View commit details
-
Copy full SHA for d02d7e4 - Browse repository at this point
Copy the full SHA d02d7e4View commit details
Commits on May 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 89ae778 - Browse repository at this point
Copy the full SHA 89ae778View commit details -
+ DietPi-Software | rTorrent: Set default pieces.memory.max.set to total physical memory size in MiB as intended + DietPi-Software | rTorrent: Fix invalid dht.mode.set value, which must be "on" instead of "enable"
Configuration menu - View commit details
-
Copy full SHA for 8aa7af2 - Browse repository at this point
Copy the full SHA 8aa7af2View commit details
Commits on May 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 16a1e9f - Browse repository at this point
Copy the full SHA 16a1e9fView commit details -
+ DietPi-Imager | Store original directory path, before navigating into temporary working dir, so dietpi-explorer can start at intended location
Configuration menu - View commit details
-
Copy full SHA for 30db40a - Browse repository at this point
Copy the full SHA 30db40aView commit details -
+ DietPi-Imager | We must navigate to origin dir, otherwise the resulting image is removed with /tmp/$G_PROGRAM_NAME on exit
Configuration menu - View commit details
-
Copy full SHA for d89c43c - Browse repository at this point
Copy the full SHA d89c43cView commit details -
+ DietPi-PREP | Install rng-tools5 as modern entropy daemon wherever it has been proven to work. Separate entropy daemon and initramfs package estimation for allow more flexible adjustments based on further tests.
Configuration menu - View commit details
-
Copy full SHA for 795ac9c - Browse repository at this point
Copy the full SHA 795ac9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f6f34c0 - Browse repository at this point
Copy the full SHA f6f34c0View commit details -
+ DietPi-Services | Add support for new Firefox Sync Server + DietPi-Software | Firefox Sync Server: Add online docs URL: https://dietpi.com/phpbb/viewtopic.php?p=24713#p24713 + DietPi-Software | Firefox Sync Server: Do not edit Makefile to use our config, instead call gunicorn with correct option directly + DietPi-Software | Firefox Sync Server: Add strict service hardening to allow R/W only to our config+database dir, the ffsync users home + DietPi-Software | Firefox Sync Server: Do not enable service on install, since it is now controlled by DietPi-Services + DietPi-Patch | Make userdata dir world-executable so service users don't need to be in dietpi group to access their data dir: #3536 (comment)
Configuration menu - View commit details
-
Copy full SHA for 96b11b0 - Browse repository at this point
Copy the full SHA 96b11b0View commit details
Commits on May 15, 2020
-
+ DietPi-Software | Deluge: Enhance uninstall to assure all service and user traces are removed
Configuration menu - View commit details
-
Copy full SHA for 27ab738 - Browse repository at this point
Copy the full SHA 27ab738View commit details -
+ README | Add Syncthing and Firefox Sync Server to 3rd party sources list
Configuration menu - View commit details
-
Copy full SHA for 25a2978 - Browse repository at this point
Copy the full SHA 25a2978View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dce3dd - Browse repository at this point
Copy the full SHA 0dce3ddView commit details -
+ DietPi-Config | Add Ethernet link speed selection to Network>Ethernet menu. The dietpi-set_hardware option and dietpi.txt entry exists for a long time, but it was only exposed as first run setup option.
Configuration menu - View commit details
-
Copy full SHA for d54eaee - Browse repository at this point
Copy the full SHA d54eaeeView commit details -
+ CHANGELOG | Added Ethernet link speed selection to Network>Ethernet menu
Configuration menu - View commit details
-
Copy full SHA for f0f4983 - Browse repository at this point
Copy the full SHA f0f4983View commit details -
+ DietPi-Config | Fix Ethernet link speed menu if no link speed force option is supported by the network adapter
Configuration menu - View commit details
-
Copy full SHA for ba45d24 - Browse repository at this point
Copy the full SHA ba45d24View commit details
Commits on May 17, 2020
-
+ Odroid XU4 | Update boot.ini: Compact HDMI-PHY control settings and expose "new" (2017) DDR frequency as an optional setting: hardkernel/u-boot@edb23d4
Configuration menu - View commit details
-
Copy full SHA for aa033a5 - Browse repository at this point
Copy the full SHA aa033a5View commit details -
+ DietPi-Imager | Error handle some more commands which allows to retry and adjust them in case of error, before exiting
Configuration menu - View commit details
-
Copy full SHA for 16324ca - Browse repository at this point
Copy the full SHA 16324caView commit details -
+ DietPi-PREP | Install fdisk on Buster+ systems, where it has become an own package. On Bullseye it has been degraded from "required" to "important", which means that it would be autoremoved otherwise. This is used by DietPi-FS_partition_resize, parted cannot be used since it does not allow to resize a partition non-interactively, currently, and does not support max resizing but only to a defined end, which must be estimated first. + DietPi-PREP | Install gdisk on systems where the root file systems is on a GPT partition, used by DietPi-FS_partition_resize + DietPi-PREP | Fix "fat" file system detection it the it is the first file system on the list. This is a failsafe step only, since those are reported as "vfat" in all known cases.
Configuration menu - View commit details
-
Copy full SHA for 510de23 - Browse repository at this point
Copy the full SHA 510de23View commit details -
+ DietPi-Imager | Remove obsolete exit calls, replace Exit_On_Fail with direct exit call and remove loopback device via G_EXIT_CUSTOM exit trap.
Configuration menu - View commit details
-
Copy full SHA for 6aa59bb - Browse repository at this point
Copy the full SHA 6aa59bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c2437f - Browse repository at this point
Copy the full SHA 1c2437fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5996c9d - Browse repository at this point
Copy the full SHA 5996c9dView commit details
Commits on May 18, 2020
-
+ DietPi-FirstBoot | Apply static DNS nameserver via /etc/resolv.conf directly, since resolvconf is not preinstalled anymore: 22131fe#diff-0e127c4cad3f8401a925d13d05b5ae87
Configuration menu - View commit details
-
Copy full SHA for bff5112 - Browse repository at this point
Copy the full SHA bff5112View commit details -
+ DietPi-Imager | Remove the loopback device only if a file is attached, since the device file exists always
Configuration menu - View commit details
-
Copy full SHA for 0b4a4d4 - Browse repository at this point
Copy the full SHA 0b4a4d4View commit details -
+ DietPi-Explorer | Print some info when processing the content of the current dir, since this ("wc -c" on all files) can take some seconds on slower drives and/or when large files are contained. ToDo: Think about scraping "ls -Al" output instead!
Configuration menu - View commit details
-
Copy full SHA for 95497ce - Browse repository at this point
Copy the full SHA 95497ceView commit details -
+ DietPi-Software | Use new method clear terminal by moving existing content into history, thus preserving it
Configuration menu - View commit details
-
Copy full SHA for edcce06 - Browse repository at this point
Copy the full SHA edcce06View commit details -
+ DietPi-PREP | Revert /tmp tmpfs size to default after it has been set by DietPi-Set_swapfile
Configuration menu - View commit details
-
Copy full SHA for 10eabd9 - Browse repository at this point
Copy the full SHA 10eabd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c39e0e0 - Browse repository at this point
Copy the full SHA c39e0e0View commit details -
+ DietPi-Globals | G_OBTAIN_CPU_TEMP: Add support for new Odroid C1 Armbian legacy Linux 5.4.40 image: https://dietpi.com/phpbb/viewtopic.php?p=24860#p24860 + DietPi-Globals | Minor coding enhancements which i.a. removes the need to pre-create G_PROMPT_BACKUP_DISABLED and G_THREADING_ENABLED variables by directly checking against the default value
Configuration menu - View commit details
-
Copy full SHA for e9ae410 - Browse repository at this point
Copy the full SHA e9ae410View commit details
Commits on May 19, 2020
-
+ DietPi-Software | Folding@Home: Update to new v7.6.X + DietPi-Software | Folding@Home: Create default config file, prevent config backup on each change + DietPi-Software | Folding@Home: Disable file logging by default, "journalctl -u fahclient" can be used instead, reduce logging level to minimum + DietPi-Software | Folding@Home: Pause on initial service start. When folding is manually started, this is overridden per-slot for next service start but prevents us from pulling a work unit even on test installs. + DietPi-Software | Folding@Home: The previous package does not need to be purged anymore before the new one can be installed + DietPi-Software | Folding@Home: It is now possible to prevent the service start on package install + DietPi-Software | Folding@Home: FAHClient will not store given command line options to a new config file anymore, hence we need to create our own default config but can skip all command line options within the systemd unit + DietPi-Software | Folding@Home: Fix signing out from all work units on uninstall + DietPi-Patch| Folding@Home: Reinstall to apply v7.6.X update, remove obsolete files and purge installed package, since the old one caused issues on reinstall
Configuration menu - View commit details
-
Copy full SHA for 6d6e3d3 - Browse repository at this point
Copy the full SHA 6d6e3d3View commit details
Commits on May 20, 2020
-
+ DietPi-Patch | Assure that correct permissions for /run/dietpi and /run/dietpi/.network are applied when creating them (pre-v6.29)
Configuration menu - View commit details
-
Copy full SHA for 99caec8 - Browse repository at this point
Copy the full SHA 99caec8View commit details -
+ DietPi-Software | Plex Media Server: On uninstall, remove systemd unit which currently survives the package purging: #3551
Configuration menu - View commit details
-
Copy full SHA for b0c23fb - Browse repository at this point
Copy the full SHA b0c23fbView commit details
Commits on May 21, 2020
-
+ DietPi-PREP | Install modern rng-tools5 on Odroid XU4 as well: #3544 (comment)
Configuration menu - View commit details
-
Copy full SHA for 5e8144b - Browse repository at this point
Copy the full SHA 5e8144bView commit details -
+ DietPi-Cloudshell | Calling the external "clear" binary is quite slow. It is possible to redirect its output to use it later with only shell-internal commands, which is orders of magnitudes faster. We could use known escape sequences here but using the sequence the "clear" estimates to be the best for the current terminal type makes it most compatible and does not change the current behaviour in any way, besides performance ;). + DietPi-Cloudshell | Minor coding enhancement
Configuration menu - View commit details
-
Copy full SHA for 6cd00ba - Browse repository at this point
Copy the full SHA 6cd00baView commit details
Commits on May 24, 2020
-
+ DietPi-PREP | ROCK Pi S: rockpis-dtbo is not required as it doubles the overlays that are already provided (among others) with the kernel package
Configuration menu - View commit details
-
Copy full SHA for 4ee75d8 - Browse repository at this point
Copy the full SHA 4ee75d8View commit details
Commits on May 25, 2020
-
+ DietPi-PREP | Do not remove /home (recreated anyway) and /media but their content only, since their existence is required to fulfil FHS and their absence can hence lead to issues: #3558, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=956495#15
Configuration menu - View commit details
-
Copy full SHA for 16d105e - Browse repository at this point
Copy the full SHA 16d105eView commit details -
+ DietPi-Software | Sonarr: Install from stable/master branch instead of develop + DietPi-Software | Sonarr/Radarr/Lidarr: Add /media to ReadWritePaths to not break instances where users use /media for their mounts: #3561 + DietPi-Software | Sonarr/Radarr/Lidarr/Jackett: When enabling services for systemd-controlled startup at boot, wait for dietpi-boot.service which is a better measure to ensure network is up and time sync as well, required for any encrypted network access where certificates timestamps must match.
Configuration menu - View commit details
-
Copy full SHA for 7a4350f - Browse repository at this point
Copy the full SHA 7a4350fView commit details
Commits on May 26, 2020
-
+ DietPi-Logclear | Resolve an issue where .db-shm and .db-wal files are were not excluded from processing, bug introduced with v6.29
Configuration menu - View commit details
-
Copy full SHA for 274434d - Browse repository at this point
Copy the full SHA 274434dView commit details
Commits on May 27, 2020
-
+ DietPi-Patch | Assure /media exists to fulfil FHS, fix htpdate service startup and probably other issues: #3558
Configuration menu - View commit details
-
Copy full SHA for 6106bd9 - Browse repository at this point
Copy the full SHA 6106bd9View commit details -
+ CHANGELOG | Resolved potential issues due to missing /media directory on DietPi images
Configuration menu - View commit details
-
Copy full SHA for 525d168 - Browse repository at this point
Copy the full SHA 525d168View commit details
Commits on May 28, 2020
-
+ DietPi-Globals | Some ordering, wording and explanation enhancements + DietPi-Globals | Set and export $LANG as well even that its effect is fully overwritten by $LC_ALL, since some 3rd party scripts/programs might check it to derive the used/default locale
Configuration menu - View commit details
-
Copy full SHA for b2be77c - Browse repository at this point
Copy the full SHA b2be77cView commit details -
+ DietPi-Set_software | locale: Minor wording enhancements + DietPi-Set_software | locale: Show output of dpkg-reconfigure call since it might be interesting which locales are actually generated and if any warnings appear + DietPi-Set_software | locale: Set and export $LANG as well, since errors can appear as well if this has an invalid value, even that its effect is fully overridden by $LC_ALL
Configuration menu - View commit details
-
Copy full SHA for 8c07e28 - Browse repository at this point
Copy the full SHA 8c07e28View commit details
Commits on May 31, 2020
-
+ DietPi-Software | Pi-hole: Allow direct access to further local fonts types, used now by AdminLTE: https://github.com/pi-hole/pi-hole/pull/3403/files#diff-db31ccc9ffd35ede6f6bf7ba1e5c8407
Configuration menu - View commit details
-
Copy full SHA for 2c95ce9 - Browse repository at this point
Copy the full SHA 2c95ce9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae27afc - Browse repository at this point
Copy the full SHA ae27afcView commit details -
+ DietPi-Software | Pi-hole: Grant admin panel access to all local fonts types: https://github.com/pi-hole/pi-hole/pull/3403/files#r432926507
Configuration menu - View commit details
-
Copy full SHA for 44d1e5b - Browse repository at this point
Copy the full SHA 44d1e5bView commit details -
+ DietPi-Software | Pi-hole: Grant admin panel access to all local fonts types: https://github.com/pi-hole/pi-hole/pull/3403/files#r432926507
Configuration menu - View commit details
-
Copy full SHA for e3297f8 - Browse repository at this point
Copy the full SHA e3297f8View commit details -
+ DietPi-PREP | Locales: Export $LANG as well as in case of invalid entry this causes an error message as well, even that it is effectively overridden by $LC_ALL. Export both after locale generation, before calling any other command.
Configuration menu - View commit details
-
Copy full SHA for b7998cf - Browse repository at this point
Copy the full SHA b7998cfView commit details -
+ DietPi-PREP | Disable dpkg state translations and skip installing recommends already on initial dependency installs
Configuration menu - View commit details
-
Copy full SHA for 6b07d8c - Browse repository at this point
Copy the full SHA 6b07d8cView commit details -
+ DietPi-Software | WireGuard: Enable for Odroid N2 and C4, remove obsolete Rock64 implementation, we'll add a generic Armbian solution at a later date. + DietPi-Software | WireGuard: The package is now available via Debian backports, hence add Bullseye repo only on RPi (there are no Raspbian backports) or Stretch.
Configuration menu - View commit details
-
Copy full SHA for d51514a - Browse repository at this point
Copy the full SHA d51514aView commit details -
+ Network | Grant all users "ping" access without the need for sudo, setuid, CAP_NET_RAW or CAP_NET_ADMIN. Further infos and discussion about this: - https://fedoraproject.org/wiki/Changes/EnableSysctlPingGroupRange - systemd/systemd#13141 - #1012
Configuration menu - View commit details
-
Copy full SHA for caec92e - Browse repository at this point
Copy the full SHA caec92eView commit details -
+ DietPi-Patch | All users are permitted to "ping" now without any further capabilities, hence remove them for security reasons: caec92e
Configuration menu - View commit details
-
Copy full SHA for e6c504d - Browse repository at this point
Copy the full SHA e6c504dView commit details -
+ CHANGELOG | "ping" can now be used by all users without any file capabilities, sudo or setuid. For this we allow all users to create native ICMP sockets which are available since Linux 3.X but disabled by default on Debian. Other distributions and systemd (upstream) have this enabled by default and for security and usability reasons we follow them: https://fedoraproject.org/wiki/Changes/EnableSysctlPingGroupRange
Configuration menu - View commit details
-
Copy full SHA for e16e82d - Browse repository at this point
Copy the full SHA e16e82dView commit details
Commits on Jun 1, 2020
-
+ README.md | Load logo from GitHub resource and the new myVirtualserver logo from their website
Configuration menu - View commit details
-
Copy full SHA for 02896ef - Browse repository at this point
Copy the full SHA 02896efView commit details
Commits on Jun 3, 2020
-
+ DietPi-Software | Samba Server: Change default server-side file permissions to 0664 (no execute permissions)
Configuration menu - View commit details
-
Copy full SHA for d9daf32 - Browse repository at this point
Copy the full SHA d9daf32View commit details -
+ CHANGELOG | Samba Server: Changed default server-side file permissions from 0775 to 0664
Configuration menu - View commit details
-
Copy full SHA for 7c4284b - Browse repository at this point
Copy the full SHA 7c4284bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98a43e5 - Browse repository at this point
Copy the full SHA 98a43e5View commit details -
+ DietPi-Cron_daily | MOTD: Error out if webserver answers with 40X error instead of storing the error response in the MOTD script
Configuration menu - View commit details
-
Copy full SHA for 2b8ab91 - Browse repository at this point
Copy the full SHA 2b8ab91View commit details -
+ DietPi-Banner | MOTD: (Re)download the MOTD not only if the file does not exist, but also if it is empty (and writable), e.g. due to a failed download before. This resolves an issue where the the first banner after a failing daily cron MOTD download did not show any MOTD. A failed download produced an empty file, hence the banner did not try a fresh download. + DietPi-Banner | MOTD: Initialise the $motd variable empty (local) to assure it is not e.g. exported from the parent shell
Configuration menu - View commit details
-
Copy full SHA for 46fca0a - Browse repository at this point
Copy the full SHA 46fca0aView commit details
Commits on Jun 4, 2020
-
+ DietPi-Globals | G_CHECK_URL_ATTEMPTS: Do not allow a value of "0" which would result in a single attempt but according to dietpi.txt it is invalid and reverted to default "2". + DietPi-Globals | Start implementation of default gateway, network interface and IP print functions, to replace DietPi-Obtain_network_details mid-term. Since network info can change during sessions, it makes sense to always estimate the current value required with an efficient function.
Configuration menu - View commit details
-
Copy full SHA for 5f348ce - Browse repository at this point
Copy the full SHA 5f348ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f556d3 - Browse repository at this point
Copy the full SHA 0f556d3View commit details
Commits on Jun 5, 2020
-
+ DietPi-Survey_report | Simplify by avoid piping and sub processes
Configuration menu - View commit details
-
Copy full SHA for b6b15d5 - Browse repository at this point
Copy the full SHA b6b15d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92b24a0 - Browse repository at this point
Copy the full SHA 92b24a0View commit details
Commits on Jun 7, 2020
-
+ DietPi-Globals | G_EXEC: Force usage of originating tty for STDIN, STDERR and STDOUT when spawning subshell for error investigation. This assures that bash recognises itself as interactive shell, regardless of stream redirection of originating shell/script. This could be done via "-i" as well but re-binding streams to tty also fixes some interactive programs which rely on STDOUT and STDERR being detected as tty [[ -t [12] ]], e.g. nano being unusable otherwise, when streams are redirected or piped to file or "tee". This is relevant for dietpi-update and dietpi-software on first login.
Configuration menu - View commit details
-
Copy full SHA for 689e152 - Browse repository at this point
Copy the full SHA 689e152View commit details
Commits on Jun 8, 2020
-
+ DietPi-PREP | Add u-boot to Odroid C4 requirements. N2 u-boot is currently pre-installed but not part of the C4 repo, as well it is not dependency of the C4 kernel. However lets assume the pre-installed N2 u-boot works, keep it to enable auto-upgrades once a dedicated C4 package has been added to the C4 repo.
Configuration menu - View commit details
-
Copy full SHA for 35fadc4 - Browse repository at this point
Copy the full SHA 35fadc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 998c564 - Browse repository at this point
Copy the full SHA 998c564View commit details -
+ DietPi-Imager | Automatically limit lzma2 threads on low RAM systems
Configuration menu - View commit details
-
Copy full SHA for 6a0d80e - Browse repository at this point
Copy the full SHA 6a0d80eView commit details -
+ DietPi-Software | On firstrun installs, flag DietPi-RAMlog for reinstall only if it is stilled marked to stay installed after all manual choices. Else this is overriding manual logging choice 0 and -3 since Apply_Logging_Choices() only touches "(( ${aSOFTWARE_INSTALL_STATE[103]} == 2 ))": #3588
Configuration menu - View commit details
-
Copy full SHA for fe170d5 - Browse repository at this point
Copy the full SHA fe170d5View commit details -
+ CHANGELOG | Logging choice: Resolved an issue where manually choosing logging options "None" and "Full" during firstrun installs did not uninstall DietPi-RAMlog as intended
Configuration menu - View commit details
-
Copy full SHA for f68580a - Browse repository at this point
Copy the full SHA f68580aView commit details
Commits on Jun 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e962936 - Browse repository at this point
Copy the full SHA e962936View commit details
Commits on Jun 14, 2020
-
+ DietPi-Drive_Manager | Move RootFS: Assure that DietPi userdata from rootfs, respectively its symlink, is copied to the target drive as well as all mountpoint directories (without content). This is achieved by excluding mounts content via tmp rootfs mountpoint and copying from there. This allows to skip excluding known tmpfs mountpoints manually and assures that source and target match 100% (aside of extended attributes and ACLs). rsync "-x" option prevents copying mounts content, but it copies permissions of mountpoint dirs according to mount options instead of those of the dir on the parent fs. This might be not wanted in cases. E.g. a shared drive or tmpfs has mounted with loose permissions to allow anyone access, but it is not wanted that everyone can access the directory below the mount point, when it is not mounted, e.g. to prevent a full rootfs and such. This might be a topic for rsync to add this behaviour by default when using "-x".
Configuration menu - View commit details
-
Copy full SHA for a9d2ea3 - Browse repository at this point
Copy the full SHA a9d2ea3View commit details -
+ CHANGELOG | DietPi-Drive_Manager: Resolved an issue where moving the RootFS to an external drive did not include DietPi userdata
Configuration menu - View commit details
-
Copy full SHA for 4efb301 - Browse repository at this point
Copy the full SHA 4efb301View commit details -
+ DietPi-Login | Allow prevention of dietpi-login call by setting/exporting $G_DIETPI_LOGIN. E.g. when shell is called as subshell of G_EXEC or dietpi-login itself, we don't want autostart programs to be launched.
Configuration menu - View commit details
-
Copy full SHA for 40ad8d3 - Browse repository at this point
Copy the full SHA 40ad8d3View commit details -
+ DietPi-Globals | G_EXEC: Prevent dietpi-login call in subshell. We do not want e.g. autostart programs to be launched, minimise overhead and the chance for nested error loops.
Configuration menu - View commit details
-
Copy full SHA for 4224ad6 - Browse repository at this point
Copy the full SHA 4224ad6View commit details -
+ DietPi-Login | Prevent automated nested dietpi-login calls from subshells
Configuration menu - View commit details
-
Copy full SHA for 7b3633e - Browse repository at this point
Copy the full SHA 7b3633eView commit details -
+ CHANGELOG | DietPi-Login: Resolved an issue where the script called itself from within the error handler subshell. Generally the error handler subshell must never call dietpi-login (and related autostart programs) and dietpi-login must never call itself from an interactive subshell. Many thanks to @nosyaardvark for reporting this issue: #3583 (comment)
Configuration menu - View commit details
-
Copy full SHA for d56c027 - Browse repository at this point
Copy the full SHA d56c027View commit details -
+ DietPi-Software | WireGuard: Installing resolvconf when choosing client setup, used by wg-quick to apply DNS
Configuration menu - View commit details
-
Copy full SHA for 8c33bba - Browse repository at this point
Copy the full SHA 8c33bbaView commit details -
+ CHANGELOG | Resolved an issue where WireGuard in client mode failed to start due to missing resolvconf. It is now installed together with WireGuard when choosing client setup. Many thanks to @Yahoo456 for reporting this issue: https://dietpi.com/phpbb/viewtopic.php?f=11&t=7783
Configuration menu - View commit details
-
Copy full SHA for aeb8b5e - Browse repository at this point
Copy the full SHA aeb8b5eView commit details
Commits on Jun 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for be14aff - Browse repository at this point
Copy the full SHA be14affView commit details -
+ CHANGELOG | DietPi-Drive_Manager: SSHFS entries in fstab are now detected and preserved
Configuration menu - View commit details
-
Copy full SHA for 60d5296 - Browse repository at this point
Copy the full SHA 60d5296View commit details -
+ DietPi-Cleaner | Enhance file search performance by skip traversing /mnt if not selected for inclusion + DietPi-Cleaner | Minor coding and wording
Configuration menu - View commit details
-
Copy full SHA for 81753f4 - Browse repository at this point
Copy the full SHA 81753f4View commit details -
+ DietPi-Cleaner | Add actually matched file to find_string + DietPi-Cleaner | Do not escape parenthesis for find command when added via variable since this is only relevant when typing it directly into the terminal. Else the backslash is interpreted literally.
Configuration menu - View commit details
-
Copy full SHA for 926cdf0 - Browse repository at this point
Copy the full SHA 926cdf0View commit details -
+ DietPi-Cleaner | Reduce output length, allowing better review in case of many matches
Configuration menu - View commit details
-
Copy full SHA for 3969369 - Browse repository at this point
Copy the full SHA 3969369View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8626ad - Browse repository at this point
Copy the full SHA a8626adView commit details -
+ CHANGELOG | DietPi-Cleaner: Enhanced performance of the files cleaner if /mnt is skipped, especially in combination with large drives or network mounts. Many thanks to @maartenlangeveld for revealing the underlying issue: #3609
Configuration menu - View commit details
-
Copy full SHA for 590ee87 - Browse repository at this point
Copy the full SHA 590ee87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cc5ae3 - Browse repository at this point
Copy the full SHA 8cc5ae3View commit details
Commits on Jun 17, 2020
-
+ DietPi-Globals | G_OBTAIN_CPU_TEMP: Revert earlier v6.31 change: ${afp_temperature[@]} must not be quoted to allow glob expansion + DietPi-Globals | G_OBTAIN_CPU_TEMP: We check for G_CHECK_VALIDINT on temp before accepting it, hence float handling is not required, especially not after "(( $temp >= 200 ))" which will always be false in case of present decimal point.
Configuration menu - View commit details
-
Copy full SHA for b64e9d6 - Browse repository at this point
Copy the full SHA b64e9d6View commit details -
+ DietPi-Survey_report | Enhance performance significantly by handling CPU times as integers until calculating final results in chosen scale. This allows to use native bash arithmetic instead of bc which is orders of magnitude faster. This became relevant since with Debian Buster bc execution in this environment somehow became very slow. Preserve CPU times scale and CPU temp 5 digits format check from DietPi-Benchmark respectively DietPi-Globals.
Configuration menu - View commit details
-
Copy full SHA for 21e93ba - Browse repository at this point
Copy the full SHA 21e93baView commit details -
+ DietPi-Software | Update HAProxy to lastest stable version: #3604
Configuration menu - View commit details
-
Copy full SHA for 8ab237f - Browse repository at this point
Copy the full SHA 8ab237fView commit details -
+ DietPi-Software | Ubooquity: Download newest version from Vae Mendis Software directly + DietPi-Software | Ubooquity: Make comics and ebooks dirs writable for "dietpi" group members (downloaders, file servers, ...) by default. + DietPi-Software | Ubooquity: Set users home dir and move logs to /var/log/ubooquity (DietPi-RAMlog). Sadly we cannot disable the log file since "journalctl -u ubooquity" doubles it. + DietPi-Software | Ubooquity: Use G_EXEC thoroughly to be most verbose about what we're doing and prevent unexpected situations because of failed user/dir creation and such.
Configuration menu - View commit details
-
Copy full SHA for 8c0279c - Browse repository at this point
Copy the full SHA 8c0279cView commit details
Commits on Jun 18, 2020
-
+ DietPi-Obtain_HW_model | RPi: Always check newest unpublished commits on revision code docs and add potential compute module 4 support. Although no info about this has been published yet, the CM4 is the only model where info in upstream kernel/firmware can be found about already, so we assume it will be released next. Most importantly G_HW_MODEL=4 is detected correctly for next release, a wrong G_HW_MODEL_NAME would be visual-only.
Configuration menu - View commit details
-
Copy full SHA for 13f88e7 - Browse repository at this point
Copy the full SHA 13f88e7View commit details
Commits on Jun 19, 2020
-
+ DietPi-Software | Node.js: libatomic1 is required to start Node since last year: #3614 + DietPi-Software | Node.js: Increase install verbosity and error handling + DietPi-Software | Certbot: Minor wording, uninstall enhancement and use follow official notation "Certbot" with lower case "b".
Configuration menu - View commit details
-
Copy full SHA for 95b8e7e - Browse repository at this point
Copy the full SHA 95b8e7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b7712d - Browse repository at this point
Copy the full SHA 3b7712dView commit details
Commits on Jun 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f22831b - Browse repository at this point
Copy the full SHA f22831bView commit details -
+ DietPi-Survey_report | Add percentages to counts + DietPi-Survey_report | Sort benchmark results by average score + DietPi-Survey_report | Minor coding and wording
Configuration menu - View commit details
-
Copy full SHA for b105a4e - Browse repository at this point
Copy the full SHA b105a4eView commit details -
+ DietPi-Survey_report | Sort CPU benchmark with shortest time (fastest CPU) on top + DietPi-Survey_report | Be precise on benchmark units
Configuration menu - View commit details
-
Copy full SHA for a1367a0 - Browse repository at this point
Copy the full SHA a1367a0View commit details
Commits on Jun 23, 2020
-
+ General | Add support for Raspberry Pi OS (64-bit) by separating RPi detection from Raspbian detection and adding new global variable: $G_RASPBIAN + DietPi-PREP | DietPi-Globals never creates .hw_model anymore, hence skip explicit script removal + DietPi-PREP | Since RPi can run Debian and Raspbian 32 and 64 bit images and kernel can be loaded in 64-bit mode on 32-bin image, we need to check if its a Debian or Raspbian image and if the primary deb package architecture is arm64 or not (armhf) to be sure what the target image should be. Override G_HW_ARCH with intended minimal CPU arch requirement and set + pass new G_RASPBIAN variable. + DietPi-PREP | raspi-copies-and-fills is only made for armhf hence skip it on 64-bit RPi images + DietPi-PREP | On RPi with Raspberry Pi OS (64-bit), armhf architecture is currently required to pull libraspberrypi packages and a few others. Keep armhf support until all expected packages have been ported to arm64. + DietPi-PREP | Prevent potential failure on u-boot install on C4 since it is pre-installed on the image but not yet present in the repo. The intention is to leave the package installed, if it was before, to allow automated upgrade to the actual C4 u-boot image once it is pushed to the repo. + DietPi-Config | Graphics driver: Add AMD graphics driver and firmware install to menu. ToDo: The Intel driver is recommended for pre~2007 chips only, this should be either made clear or the entry should be removed. Post~2007 Intel chips are better supported by native Xorg modesetting. + DietPi-Config | Display resolution: Add new RPi4 full KMS GL driver overlay. This has been added with Linux 5.4, which is at time of writing not yet released, but we'll add it now regardless to be prepared. + DietPi-Config | Audio options: Add new RPi sound card overlays + DietPi-Config | Minor coding and wording + DietPi-Globals | G_EXEC: Add info about Raspbian vs Debian RPi image to bug report printout + DietPi-Survey | Add new G_RASPBIAN to upload file on RPi, so we can watch the development of Raspberry Pi OS (64-bit) usage, or in theory other Debian images on RPi + DietPi-Survey_report | Add RPi Raspbian vs Debian stats + DietPi-Survey_report | Make table headers links to their ID for easier selection and references + DietPi-Config | Do not store none|N/A placeholder text in variables if it is used as inputbox default but not an actual valid value, instead start with an empty inputbox then. + DietPi-Config | Fix shown boot wait for network state + DietPi-Config | Align G_CHECK_URL timeout and attempts wording and value range with dietpi.txt info and what wget+ping commands allow.
Configuration menu - View commit details
-
Copy full SHA for 824917b - Browse repository at this point
Copy the full SHA 824917bView commit details
Commits on Jun 24, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 772936d - Browse repository at this point
Copy the full SHA 772936dView commit details -
+ DietPi-PREP | Remove "pi" user autologin on Raspberry Pi OS (64-bit): #3570 (comment)
Configuration menu - View commit details
-
Copy full SHA for 3f4cc7b - Browse repository at this point
Copy the full SHA 3f4cc7bView commit details -
+ DietPi-Imager | Open interactive bash subshell for image content review/changes if user chooses to + DietPi-Imager | Wrap fsck into G_EXEC error handler to allow rerun in case of found errors, wrap more commands into G_EXEC to prevent unexpected states and increased verbosity
Configuration menu - View commit details
-
Copy full SHA for 4924679 - Browse repository at this point
Copy the full SHA 4924679View commit details -
+ DietPi-Globals | Remove G_GET_NET* functions until concept has been finished, probably postpone to next release
Configuration menu - View commit details
-
Copy full SHA for 4e10fbb - Browse repository at this point
Copy the full SHA 4e10fbbView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 66f937a - Browse repository at this point
Copy the full SHA 66f937aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd45e90 - Browse repository at this point
Copy the full SHA dd45e90View commit details
Commits on Jun 25, 2020
-
+ DietPi-PREP | Ship full GPLv2 license text, being good practise
Configuration menu - View commit details
-
Copy full SHA for a1033d3 - Browse repository at this point
Copy the full SHA a1033d3View commit details -
+ dietpi.txt | Allow to skip the interactive license dialog via new setting AUTO_SETUP_ACCEPT_LICENSE=1. This resolves an issue where firstrun setup is done non-interactively (AUTO_SETUP_AUTOMATED=1) and a non-input autostart options is chosen, e.g. Chromium kiosk mode with no keyboard attached: #3326
Configuration menu - View commit details
-
Copy full SHA for 1a3dcac - Browse repository at this point
Copy the full SHA 1a3dcacView commit details -
+ DietPi-Login | Skip interactive license dialog if it has been accepted via new dietpi.txt setting: AUTO_SETUP_ACCEPT_LICENSE=1
Configuration menu - View commit details
-
Copy full SHA for adf1409 - Browse repository at this point
Copy the full SHA adf1409View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfbc502 - Browse repository at this point
Copy the full SHA dfbc502View commit details -
+ CHANGELOG | DietPi-Login | A new setting has been added which allows to skip the interactive GPLv2 license agreement on first login. Add/set "AUTO_SETUP_ACCEPT_LICENSE=1" in (/boot/)dietpi.txt in which case we assume you read and agreed the license text at least once. Many thanks to @mrbluecoat for reporting the urgent use-case of Chromium kiosk mode autostart without keyboard attached: #3326
Configuration menu - View commit details
-
Copy full SHA for 3d3dcfd - Browse repository at this point
Copy the full SHA 3d3dcfdView commit details -
+ DietPi-Software | TigerVNC: Workaround external bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932499 + DietPi-Software | TigerVNC: Missing netbase dependency has been resolved since Bullseye + DietPi-Software | VNC Server: Check for RealVNC/TigerVNC binaries explicitly, else exit with error + DietPi-Software | XRDP: Do not apply backports rules on Raspbian + DietPi-Software | QuiteRSS: Re-add install code, which was (accidentally?) removed/left commented with DietPi v127 commit: 7cb41f3
Configuration menu - View commit details
-
Copy full SHA for 49f960a - Browse repository at this point
Copy the full SHA 49f960aView commit details -
+ CHANGELOG | QuiteRSS: Re-added the years ago accidentally removed install code block. If you ever wondered why there was no QuiteRSS after selecting it for install, now there will be. If it is marked as installed already, run either "dietpi-software install 22" or simply "apt install quiterss" to (really) get it. + CHANGELOG | TigerVNC: Worked around an external bug where the VNC server crashes after client logout. Many thanks to @Joulinar for investigating this issue and providing the workaround: https://dietpi.com/phpbb/viewtopic.php?p=25285#p25285
Configuration menu - View commit details
-
Copy full SHA for bc21cfb - Browse repository at this point
Copy the full SHA bc21cfbView commit details -
+ DietPi-Patch | Avoid setcap error message by attempting capability removal only if any are present + DietPi-Patch | Reset QuiteRSS install state if the package has not actually been installed: 49f960a + DietPi-Patch | Fix obsolete FAHClient service removal
Configuration menu - View commit details
-
Copy full SHA for 59b2ccf - Browse repository at this point
Copy the full SHA 59b2ccfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 938e537 - Browse repository at this point
Copy the full SHA 938e537View commit details -
+ DietPi-Patch | getcap always returns true, so we need to check for output instead
Configuration menu - View commit details
-
Copy full SHA for 22d929b - Browse repository at this point
Copy the full SHA 22d929bView commit details -
+ DietPi-Software | WireGuard: Enable support for all devices where the kernel module is shipped with the kernel package. This is e.g. true for all "current" Armbian images with 5.X kernel. WireGuard has been natively integrated into Linux since v5.6 hence this integration will be of raising importance and allows to skip DKMS and headers install. + DietPi-Software | WireGuard: Work around an issue with some Odroids where /lib/modules/<version>/build symlink is missing when headers are installed after the kernel package. If a matching kernel and headers dir pair is found but no symlink, it is created now manually: #3577
Configuration menu - View commit details
-
Copy full SHA for ca8ec0e - Browse repository at this point
Copy the full SHA ca8ec0eView commit details
Commits on Jun 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2039bcf - Browse repository at this point
Copy the full SHA 2039bcfView commit details -
+ DietPi-Software | Minor wording/comments and shortened forum URLs
Configuration menu - View commit details
-
Copy full SHA for 5aa2cac - Browse repository at this point
Copy the full SHA 5aa2cacView commit details
Commits on Jun 27, 2020
-
+ DietPi-Software | Desktops: Shared desktop entries/icons are hosted on GitHub for a while, hence remove the obsolete dietpi.com URL check. + DietPi-Software | MATE: Install the core package only, the extra package is a meta package that pulls (as dependency) only the base package which again pulls (as dependency) only the core package. Hence without explicitly pulling recommendations, we just install two meta packages + core and should instead install core only.
Configuration menu - View commit details
-
Copy full SHA for 62bbaad - Browse repository at this point
Copy the full SHA 62bbaadView commit details -
+ DietPi-Software | TigerVNC: Apply libunwind workaround via binary patch, which fixes calls from other origins like XRDP + DietPi-Software | RealVNC: Do not enable enterprise subscription service vncserver-virtuald. If users have enterprise subscription, they should disable our vncserver.service and enable vncserver-virtuald.service to switch from static VNC session on screen 1 to ondemand RealVNC session spawn. + DietPi-Software | RealVNC: Integrate vncserver-x11-serviced.service start into vncserver.service in shared mode. Having it running concurrently to a virtual VNC session makes it attaching to the virtual VNC session, which allows connecting to it on port 5900 (no screen :1 required) but the overhead overhead of ~20 MiB + possible confusion is not worth it. + DietPi-Software | VNC Servers: Apply vncpasswd only on TigerVNC since RealVNC by default uses UNIX user authentication and does not support the "-f" option at all. + DietPi-Software | VNC Servers: Minor uninstall enhancements
Configuration menu - View commit details
-
Copy full SHA for f96ad09 - Browse repository at this point
Copy the full SHA f96ad09View commit details -
+ DietPi-Software | TigerVNC: Hide "dpkg-query -s" output + DietPi-Software | TigerVNC: Print "'Waiting for X11 to start" only one on shared mode startup, then wait silently. As of service type, subsequent prints are no caught anymore by journal and otherwise would spam it in case of disabled desktop autologin.
Configuration menu - View commit details
-
Copy full SHA for c8d20a1 - Browse repository at this point
Copy the full SHA c8d20a1View commit details
Commits on Jun 28, 2020
-
+ CHANGELOG | XRDP: The TigerVNC bug affected as well XRDP connections which have been resolved in the same turn: #3615 (comment)
Configuration menu - View commit details
-
Copy full SHA for e09fc03 - Browse repository at this point
Copy the full SHA e09fc03View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4a1dc3 - Browse repository at this point
Copy the full SHA c4a1dc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a688920 - Browse repository at this point
Copy the full SHA a688920View commit details -
+ DietPi-Patch | On Stretch, libcap2-bin ist no dependency of iproute2 and can hence be missing. Skip ping binary capability removal, if getcap/setcap is missing anyway. No need to force its install, security implication is minimal anyway.
Configuration menu - View commit details
-
Copy full SHA for 7f5c40c - Browse repository at this point
Copy the full SHA 7f5c40cView commit details -
+ DietPi-FirstBoot | Network setup: Although we do not ship our images with resolvconf anymore, be more compatible and apply static DNS nameservers correctly when it is present.
Configuration menu - View commit details
-
Copy full SHA for d0b33bc - Browse repository at this point
Copy the full SHA d0b33bcView commit details -
+ DietPi-Cleaner | Only mark packages for autoremoval if any were found + DietPi-Cleaner | Do not mark git as as not installed since we do not autoremove it anymore, since is required by some software titles for their internal updaters.
Configuration menu - View commit details
-
Copy full SHA for 01dafdd - Browse repository at this point
Copy the full SHA 01dafddView commit details -
+ DietPi-Software | WiFi Hotspot: In case of RTL8188C* adapter on RPi, stay with default driver, since the issue seems to have been resolved differently and "rtl871xdrv" is not supported: #2531 (comment)
Configuration menu - View commit details
-
Copy full SHA for e1c88c3 - Browse repository at this point
Copy the full SHA e1c88c3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.