DietPi-Software | Make Go an own install option (ID=188) #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok working fine on RPi OS 32bit + 64bit |
Joulinar
previously approved these changes
Apr 14, 2021
MichaIng
changed the title
|
I switched to automatic Go version detection. From the install docs, which use JavaScript to always show the latest version, I found a JSON version of the download page which can be effectively scraped. Note: For now we keep /mnt/dietpi_userdata/go in place on uninstall. This is where package installs, custom compilations, downloaded sources etc are stored. This is especially important as long as we don't have a good dependency system that blocks uninstalls of dependencies. Otherwise it would be possible to uninstall Go while OpenBazaar is installed, but together with /mnt/dietpi_userdata/go, OpenBazaar would be gone, too. |
+ DietPi-Software | Main menu entry renaming: #4270 (comment)
+ DietPi-Software | Go: Omit curl error 23 as "grep -m1" terminates the pipe when found the first match. The page is too large for the curl cache to have the download fully completed, like it is for "api.github.com/.../latest" pages. This omits all curl errors, which is okay as of the G_DIETPI-NOTIFY below, which makes us verify the download already.
+ DietPi-Software | Go: Since Go v1.16, GOPATH vs module mode is not auto-detected anymore by default, but module mode is forced. Since we want to install and control package instances in our defined GOPATH, revert this change via /etc/bashrc.d/go.sh for bash shell sessions, so that the presence of a go.mod file in cwd triggers module mode, while otherwise GOPATH is used: https://golang.org/ref/mod#mod-commands + DietPi-Software | OpenBazaar: Remove doubled install notification and force GOPATH mode + DietPi-Software | OpenBazaar: Add documentation URL to systemd unit and assure it starts after network is up to allow IP binding + DietPi-Software | OpenBazaar: Error-handle init and credentials input, as e.g. when not being able to confirm/repeat the password, there is no clean way to retry: CTRL+C terminates the attempt, but leaves the instance without credentials set and more importantly it leaves the terminal in a broken state, manipulated by OB to hide the typed password and not reset on regular termination, which is bad. Piping the output through "tee" via G_EXEC_OUTPUT=1 limits the terminal manipulation to the tee instance, so exiting or retrying can be done fine.
+ DietPi-Software | OpenBazaar: Make build verbose to allow following the longer taking process + DietPi-Software | YaCy: Detect latest version automatically, using a similar method as with OpenBazaar + DietPi-Software | YaCy: Start enabled service after network, to allow IP binding, and add official Wiki to systemd documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Ready
Commit list/description: