Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DietPi-Drive_Manager | Move Samba credentials from /etc/fstab to separate per-mount credentials file #4290

Merged
merged 3 commits into from
Apr 20, 2021
Merged

DietPi-Drive_Manager | Move Samba credentials from /etc/fstab to separate per-mount credentials file #4290

merged 3 commits into from
Apr 20, 2021

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Apr 20, 2021 •
edited
Loading

Status: Ready

Commit list/description:

  • DietPi-Drive_Manager | Move Samba credentials from /etc/fstab to separate per-mount credentials file

@MichaIng
v7.1
bbcb6c4 
+ DietPi-Drive_Manager | Move Samba credentials from /etc/fstab to separate per-mount credentials file
@MichaIng MichaIng added this to the v7.1 milestone Apr 20, 2021
@MichaIng MichaIng linked an issue Apr 20, 2021 that may be closed by this pull request
dietpi-drive_manager stores network usernames & passwords in clear text in world-readable fstab file #4082
Closed
@MichaIng
v7.1
21539a4 
+ CHANGELOG | DietPi-Drive_Manager: When adding Samba mounts, credentials are not added in plain text to /etc/fstab anymore, but stored instead in a separate per-mount credential file with strict root-only read permissions.
@MichaIng
v7.1
69e4634 
+ DietPi-Drive_Manager | Credentials file needs to be removed before unmounting the network drive, else ${aDRIVE_MOUNT_TARGET[$MENU_DRIVE_INDEX]} is empty.
@MichaIng MichaIng merged commit ee35cec into dev Apr 20, 2021
@MichaIng MichaIng deleted the samba branch April 20, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Security 🔒
Projects
None yet
Milestone
v7.1
Development

Successfully merging this pull request may close these issues.

dietpi-drive_manager stores network usernames & passwords in clear text in world-readable fstab file
1 participant
@MichaIng