DietPi-Software | Rework dependency and choice system

[ravenclaw900]

Status: Testing

• Migrate all software to use new system
• Add dummy IDs for webserver/desktop/browser EDIT: Not used anymore. Another way to resolve such meta dependencies has been implemented.
• Add own Firefox install option
• Add browser meta dependency, used by desktops
• Add desktop default menu
• Add browser default menu

Reference: #3921 (comment)

Commit list/description:

• DietPi-Software | Begin to rework dependency system
• DietPi-Software | Begin to switch to new system

[MichaIng]

Awesome start with this, many thanks!

• We can corporate all this "Software that requires XYZ"/"Software required by XYZ" stuff as well.
• For webserver and desktop, I through about some kind of "OR" operator. But in case of webserver, it needs to be handled specially anyway to respect the preference system. And I want a desktop preference menu as well, as currently LXDE is always chosen, if no desktop is installed or selected but required. Same could follow for browsers, after making Firefox an own install option. We could add a dummy webserver and desktop software ID. In the loop we then check the these IDs specifically to handle them, e.g. in a different function to keep it clean, which basically changes the $j ID based on the preference. An important difference for those is that webservers and desktops are never reinstalled (< 1), while all other dependencies are (!= 1). We should keep that behaviour for now until we're able to rework them to not overwrite existing configs.
• And we need to do the loop incrementally. My idea was to make inner dependency loop for j in "${aSOFTWARE_REQUIRES[@]}" an own function with the current outer loop software ID as input, which continues, if a dependency is already set to 1, else calls itself with the current dependency as input. The == 1 )) && continue is important then to avoid unlimited nesting.

[ravenclaw900]

We could add a dummy webserver and desktop software ID.

What about automated upgrades and user input?

[MichaIng]

So far so good. Ready for testing and review. First install test with XRDP, Xfce an "no" browser preference. X server + ALSA and those preferences are selected correctly.

[Joulinar]

do we need to check other software title who have dependency as well?

[MichaIng]

It doesn't hurt to test others, just to verify the general functionality of this dependency system.

[Joulinar]

ok I did 3 basic checks

1. NextCloud - all dependency installed as expected
2. XRDP with LXDE and Chromium - all dependency installed as expected
3. Docker-Compose + Portainer - all dependency installed as expected

[MichaIng]

Great, I also ran a few tests installs and reinstalls and added some debug output to all parts of the loop. It works pretty well as expected 💯. I'll add the changelogs and merge it then.