-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DietPi-Software | Refactoring #4386
Conversation
+ DietPi-Software | Remove obsolete reset of choice and preference system during first run. The variables are declared with defaults and during first run, dietpi.txt settings or defaults are parsed and applied within the first run code block already. Align those defaults with what is intended. + DietPi-Software | Remove USB drive check and flag. It is basically wrong since /dev/sda1 is not necessarily a USB drive while it could be /dev/sd[a-z][1-9]. However, keep the two cases where it is used functionally untouched by explicitly checking findmnt there. + DietPi-Software | emonHub: Align API key input boxes with each other. The one shown when selecting emonHub from the list has been overseen when a second one has been implemented into the install section. It is however fine to have both, as the old one is shown more nicely during software selection, but not shown when the CLI is used, so the new one serves as fallback. + DietPi-Software | Do not reinstall DietPi-RAMlog on first run, instead apply the dietpi.txt RAMlog size within the first run block + DietPi-Software | Only store installed software in the state file + DietPi-RAMlog and Dropbear, as those are initialised as installed, matching our image defaults
+ DietPi-Software | Do not install own Realtek hostapd package anymore. It is old, requires ancient libssl1.0.0 and is only required for non-RPi non-x86 non-Armbian SBCs with such a special Realtek WiFi adapter attached. And there were still cases where it simply didn't work. + DietPi-Software | LibSSL1.0.0: Remove install option, as it is not required anymore + DietPi-Software | Merge first run DietPi-Automation steps into two dedicated functions, one prior to installs, where no network is strictly required, one afterwards. + DietPi-Software | Rename aSOFTWARE_* array names to have the same length, because we can :)
+ DietPi-Software | Enhance software selection menu a bit: Previous selections in the same session won't be lost when exiting the checklist (ESC/"Back"), but previously already made selections will stay intact. Only when confirming (ENTER/RETURN/"Ok"), selections will be updated based on checklist tacks.
Some sorting and cleanup of the code and old obsolete functions/items done. I have further ideas:
But this is for next release, for now having some old obsolete stuff removed and tidied should be fine and is good to include into regular testing til release. |
it's fine to merge install + config function blocks but there we would need to ensure to have the correct order of software title as some depends on others. Like: NextCloud depends on database + redis + web server |
Yes that is true. In most cases this should be correctly ordered already, but important to review it. This makes is a larger task as well, copy&paste a code block, then verify all dependencies are installed before that block, for each software title 😃. Also here, making those separate functions would allow us to install dependencies first and dependants afterwards, with a generic method similar to the new dependency mark system, or even as part of the same loop, performing the install directly instead of setting the mark. The more I think about it the more I'm sure that this is something for a future version 😄. |
Status: Ready
Commit list/description: